Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required virtual method ScriptLanguage::_preferred_file_name_casing must be overridden before calling #91569

Closed
Naros opened this issue May 4, 2024 · 1 comment · Fixed by #91570
Milestone

Comments

@Naros
Copy link
Contributor

Naros commented May 4, 2024

Tested versions

4.3.dev6

System information

Windows 11 / Ubuntu 20 / Fedora 40

Issue description

The implementation of ScriptLanguageExtension::preferred_file_name_casing is not backward compatible and results in the error that the method is not implemented when opening the Create Script dialog.

I think it would be better for extension authors that new methods continue to take a reasonable default and not explicitly require implementation, especially if the method is implementing customizable behavior when there as a previous default behavior. This gives the freedom for extension authors to implement this when it seems reasonable or applicable.

Steps to reproduce

  1. Implement custom script extension and language.
  2. Cick new script to open the Create Script dialog
  3. Error is reported in the output panel

Minimal reproduction project (MRP)

N/A

@Naros
Copy link
Contributor Author

Naros commented May 4, 2024

Fix in the works, testing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants