Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default implementation of ScriptLanguageExtension::preferred_file_name_casing #91570

Merged
merged 1 commit into from May 7, 2024
Merged

Add default implementation of ScriptLanguageExtension::preferred_file_name_casing #91570

merged 1 commit into from May 7, 2024

Conversation

Naros
Copy link
Contributor

@Naros Naros commented May 4, 2024

Fixes #91569

@Naros Naros requested a review from a team as a code owner May 4, 2024 23:37
@Naros Naros mentioned this pull request May 5, 2024
Merged
@Chaosus Chaosus added this to the 4.3 milestone May 5, 2024
@dsnopek dsnopek requested a review from a team May 6, 2024 22:42
dsnopek
dsnopek approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I didn't do any testing, but the code looks good to me :-)

@akien-mga akien-mga merged commit a1905b8 into godotengine:master May 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdextension
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Required virtual method ScriptLanguage::_preferred_file_name_casing must be overridden before calling
4 participants
@Naros @akien-mga @dsnopek @Chaosus