Change default curve range for particle angles to [-1, 1] #91421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
|
I didn't test, but this might also need to be adjusted for CPUParticles3D and CPUParticles2D in Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow). |
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
ghost
closed this by deleting the head repository
|
Was there some problem with this pr? Is it salvageable? |
|
The changes are correct, but the OP seems to have deleted their GitHub account... So yeah, someone else needs to redo it. |
|
I'm available, I'll do it |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default curve range for particle angles from [-360, 360] to [-1, 1].
Fixes #91404