Change bulk_theme_override
variable to an integer
#91563
+8
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: The value being a boolean caused issues with editor plugins that modified active themes. Even when the user calls
begin_bulk_theme_override()
themselves, engine would internally callbegin_bulk_theme_override()
andend_bulk_theme_override()
, essentially overwriting the previous override call.Related proposal
Bugsquad edit: Closes godotengine/godot-proposals#9672