Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ConnectDialog::_filter_method_list to be case insensitive for search string #91598

Merged
merged 1 commit into from May 6, 2024
Merged

Update ConnectDialog::_filter_method_list to be case insensitive for search string #91598

merged 1 commit into from May 6, 2024
+1 −1

Conversation

Frozenfire92
Copy link
Contributor

@Frozenfire92 Frozenfire92 commented May 5, 2024 •
edited by KoBeWi

Closes godotengine/godot-proposals#9679

This should make it more inline with other search boxes in the editor. Unsure if there is an existing paradigm, or just .to_lower() as I did here

@Frozenfire92 Frozenfire92 mentioned this pull request May 5, 2024
Closed
@KoBeWi KoBeWi added this to the 4.x milestone May 5, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 5, 2024
AThousandShips
AThousandShips approved these changes May 6, 2024
View reviewed changes
editor/connections_dialog.cpp Outdated Show resolved Hide resolved
@AThousandShips AThousandShips mentioned this pull request May 6, 2024
Merged
@Frozenfire92 @AThousandShips
Update ConnectDialog::_filter_method_list to be case insensitive for …
94e5bad 
…search string

Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@Frozenfire92 Frozenfire92 force-pushed the select-method-search-insensitive branch from 9df26b7 to 94e5bad Compare May 6, 2024 12:06
@akien-mga akien-mga changed the title Update ConnectDialog::_filter_method_list to be case insensitive for search string Update ConnectDialog::_filter_method_list to be case insensitive for search string May 6, 2024
@akien-mga akien-mga merged commit d8aa2c6 into godotengine:master May 6, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented May 6, 2024 •
edited

Thanks! And congrats for your first merged Godot contribution 🎉

fire pushed a commit to V-Sekai/godot that referenced this pull request May 7, 2024
@akien-mga @fire
Merge pull request godotengine#91598 from Frozenfire92/select-method-…
279ddc1 
…search-insensitive

Update `ConnectDialog::_filter_method_list` to be case insensitive for search string

Add csg boolean operators using elalish/manifold.

Add material merging.
Clear the material too.

Don't copy the manifold.

Debug.

Save.

Revert "Save."

This reverts commit b99959338c32ed74b4f7924fc870a04eb47d3607.

Revert "Debug."

This reverts commit ceb3fd1a36c7b92191cafad637535cf727377b19.

Back to the basics.

Restore working.

Geometry go brr.

Restore.

Updated submodule thirdparty/manifold
Don't crash on the empty case.

Snap to 10cm.

Use the exact snap value.

Disable uvs.

Revert "Disable uvs."

This reverts commit cfa94ad.

Revert "Use the exact snap value."

This reverts commit 5e70e10.

Save.

Don't copy.

Add vertex normals.

Revert "Add vertex normals."

This reverts commit 442dea6.

Refine, unrefine.

Remove snap

Refine before too.

Simplify.

Restore csg properties.

Start simple again.

Updated submodule thirdparty/manifold
Remove refine.

Restore materials.

Link the manifold meshes.

Set as original and generate normals.

Save.

Restore working.

Restore working.

Restore csg with properties.

Save property work for csg.

Block android and javascript for csg.

Updated submodule thirdparty/manifold
Updated submodule thirdparty/manifold
Try to avoid crashes.

Updated submodule thirdparty/manifold
Increase the tolerance.

Updated submodule thirdparty/manifold
Updated submodule thirdparty/manifold

Removed submodule thirdparty/manifold

Update.

Add manifold.

Add manifold.

Update latest manifold.

git subrepo clone --branch=7ddc1359a4b3d8f8c9327b5fdeda458ef897acf8 https://github.com/V-Sekai/manifold.git thirdparty/manifold

subrepo:
  subdir:   "thirdparty/manifold"
  merged:   "7ddc1359a4"
upstream:
  origin:   "https://github.com/V-Sekai/manifold.git"
  branch:   "7ddc1359a4b3d8f8c9327b5fdeda458ef897acf8"
  commit:   "7ddc1359a4"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

git subrepo clone --branch=e55c67d34cdb933408bbbc081c37dc2c5abeb07d https://github.com/fire/thrust.git thirdparty/manifold/third_party/thrust

subrepo:
  subdir:   "thirdparty/manifold/third_party/thrust"
  merged:   "e55c67d34c"
upstream:
  origin:   "https://github.com/fire/thrust.git"
  branch:   "e55c67d34cdb933408bbbc081c37dc2c5abeb07d"
  commit:   "e55c67d34c"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

git subrepo clone --branch=bf71a834948186f4097caa076cd2663c69a10e1e https://github.com/g-truc/glm.git thirdparty/manifold/third_party/glm

subrepo:
  subdir:   "thirdparty/manifold/third_party/glm"
  merged:   "bf71a83494"
upstream:
  origin:   "https://github.com/g-truc/glm.git"
  branch:   "bf71a834948186f4097caa076cd2663c69a10e1e"
  commit:   "bf71a83494"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

Update manifold to use exceptions.

Update csg.

git subrepo pull --remote=https://github.com/elalish/manifold.git --branch=master --force thirdparty/manifold

subrepo:
  subdir:   "thirdparty/manifold"
  merged:   "5301542254"
upstream:
  origin:   "https://github.com/elalish/manifold.git"
  branch:   "master"
  commit:   "5301542254"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

Update csg.

git subrepo clone --branch=b06b775c1c80af51a1183c0e167f9de3b2351a79 https://github.com/g-truc/glm.git thirdparty/manifold/thirdparty/glm

subrepo:
  subdir:   "thirdparty/manifold/thirdparty/glm"
  merged:   "b06b775c1c"
upstream:
  origin:   "https://github.com/g-truc/glm.git"
  branch:   "b06b775c1c80af51a1183c0e167f9de3b2351a79"
  commit:   "b06b775c1c"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

update csg.

git subrepo clone --branch=2.1.0 https://github.com/NVIDIA/thrust.git thirdparty/manifold/thirdparty/thrust

subrepo:
  subdir:   "thirdparty/manifold/thirdparty/thrust"
  merged:   "3cd56842c9"
upstream:
  origin:   "https://github.com/NVIDIA/thrust.git"
  branch:   "2.1.0"
  commit:   "3cd56842c9"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

git subrepo clone (merge) --branch=b2e8bccb8c0cd15279974fe4b9b8d6fcd1842b57 https://github.com/NVIDIA/cub.git thirdparty/manifold/thirdparty/thrust/dependencies/cub

subrepo:
  subdir:   "thirdparty/manifold/thirdparty/thrust/dependencies/cub"
  merged:   "b2e8bccb8c"
upstream:
  origin:   "https://github.com/NVIDIA/cub.git"
  branch:   "b2e8bccb8c0cd15279974fe4b9b8d6fcd1842b57"
  commit:   "b2e8bccb8c"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

git subrepo clone --branch=55dd2c99346baa3a14949a0f7e9c41865e434eda https://github.com/NVIDIA/libcudacxx.git thirdparty/manifold/thirdparty/thrust/dependencies/libcudacxx

subrepo:
  subdir:   "thirdparty/manifold/thirdparty/thrust/dependencies/libcudacxx"
  merged:   "55dd2c99346"
upstream:
  origin:   "https://github.com/NVIDIA/libcudacxx.git"
  branch:   "55dd2c99346baa3a14949a0f7e9c41865e434eda"
  commit:   "55dd2c99346"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

Update csg.

git subrepo clone (merge) --branch=1ffbc6f884ea1da89e104a5996cf8a726db673d5 https://github.com/akuukka/quickhull.git thirdparty/manifold/src/third_party/quickhull

subrepo:
  subdir:   "thirdparty/manifold/src/third_party/quickhull"
  merged:   "1ffbc6f884e"
upstream:
  origin:   "https://github.com/akuukka/quickhull.git"
  branch:   "1ffbc6f884ea1da89e104a5996cf8a726db673d5"
  commit:   "1ffbc6f884e"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"

CSG compiles!!.

CSG working!?

Save

Revert "Save"

This reverts commit 91e5ce2.

Save broken.

Revert "Save broken."

This reverts commit 89a5d57.

Save.

Cleanup

Cleanup.

Remove testing directory.

Remove git ignored filed.

Use property tolerance.

Remove git submodules

Refine error condition.

Remove magical constants.

Remove unused.

Reduce constant usage.

Avoid manifold glm compiler warning.

Fix compiler error

Try complex condition.

The function now always returns y - x, and sets Borrow to 0 if x is greater than or equal to y, and to 1 otherwise.

Supress warnings.

Disable threads on the web.

Remove clipper exceptions

Add web platform special defines for manifold.

Define uninitialized values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Make Select Method search box case insensitive
4 participants
@Frozenfire92 @akien-mga @KoBeWi @AThousandShips