Add MultiNodeEdit support to MeshInstance3D editor #91620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 6, 2024
KoBeWi
force-pushed
the
a_mesh_for_everyone
branch
from
6ce9715
to
8a39816
Compare
KoBeWi
force-pushed
the
a_mesh_for_everyone
branch
from
8a39816
to
c344e59
Compare
akien-mga
approved these changes
May 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91592
MultiNodeEdit needs to be handled explicitly now. The previous behavior was a bug tbh, the editor only worked because MultiNodeEdit was edited as a Resource, not as a Node.
Also fixes a regression from #86627 (I think) where multiple sibling nodes would be added with wrong indices/names.