Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Re-add CHANGED_FILES logic for pre-commit checks #91835

Conversation

akien-mga
Copy link
Member

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on that some checks now show "passed" instead of "skipped" this seems to be working correctly

@Repiteo
Copy link
Contributor

Repiteo commented May 11, 2024

I'm curious if explicitly passing files overrides certain include/exclude logic; probably not a concern, but it's unfortunate that pre-commit doesn't have an automatic system for this

@AThousandShips
Copy link
Member

It has an automatic system, it just doesn't work for existing commits, and doesn't seem to support listing a relative reference etc.

@akien-mga
Copy link
Member Author

I'm curious if explicitly passing files overrides certain include/exclude logic

Seems fine:

$ git diff --staged
diff --git a/thirdparty/mbedtls/library/aes.c b/thirdparty/mbedtls/library/aes.c
index b1a5c3ed10..2fea85495c 100644
--- a/thirdparty/mbedtls/library/aes.c
+++ b/thirdparty/mbedtls/library/aes.c
@@ -4,6 +4,12 @@
  *  Copyright The Mbed TLS Contributors
  *  SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
  */
+
+
+
+
+
+
 /*
  *  The AES block cipher was designed by Vincent Rijmen and Joan Daemen.
  *
$ pre-commit run --files thirdparty/mbedtls/library/aes.c
clang-format.........................................(no files to check)Skipped
black................................................(no files to check)Skipped
mypy.................................................(no files to check)Skipped
codespell............................................(no files to check)Skipped
eslint-engine........................................(no files to check)Skipped
eslint-libs..........................................(no files to check)Skipped
eslint-sw............................................(no files to check)Skipped
eslint-html..........................................(no files to check)Skipped
make-rst.............................................(no files to check)Skipped
doc-status...........................................(no files to check)Skipped
jsdoc................................................(no files to check)Skipped
copyright-headers....................................(no files to check)Skipped
header-guards........................................(no files to check)Skipped
file-format..........................................(no files to check)Skipped
dotnet-format........................................(no files to check)Skipped

@akien-mga akien-mga merged commit bdc0316 into godotengine:master May 11, 2024
16 checks passed
@akien-mga akien-mga deleted the ci-static-checks-readd-CHANGED_FILES-logic branch May 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Style checks are broken
3 participants