Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate all the cobra cli commands under cli Folder #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bishal7679
Copy link
Contributor

Part of fixing #11

Previous State

  • Previously, cobra CLI commands/flags were bit messed up
  • Codebase was unstructured

Current Behaviour

part 1

  • Restructured the whole codebase with efficient manner
  • Separated all the cobra functions eg. func CreateProjectCommand() *cobra.Command to cli/cmd folder with root.go which is for adding all the cobra cli func with RootCmd. This cobra func is using all the RunFunction from api folder i.e. apis.go

Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
@JaeAeich
Copy link
Contributor

IMO, the code base structure follows the recommended guidelines, especially using the internal folder this PR removes.
Maybe some things can be restructured, but I don't think it is needed.

PS: I don't want to be intrusive, just an opinion.

@bishal7679
Copy link
Contributor Author

IMO, the code base structure follows the recommended guidelines, especially using the internal folder this PR removes. Maybe some things can be restructured, but I don't think it is needed.

PS: I don't want to be intrusive, just an opinion.

Actually here the main aim is to separate all the jargons cli, api which would be more efficient for any contributor also to understand the codebase easily. And PR #16 adding internal/pkg folder which is also signifying all the internal package being utilized!
WDYT?

Copy link
Contributor

@amands98 amands98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the current folder structure; restructuring isn't necessary as effort has already been invested in this PR.

@bishal7679
Copy link
Contributor Author

bishal7679 commented Feb 16, 2024

Let's keep the current folder structure; restructuring isn't necessary as effort has already been invested in this PR.

Let's wait for @Vad1mo what this PR seems to him as it also took a lot of effort and interrelated with #16 to separate the whole api and cli. Doesn't it make this codebase more enhanced than previous state in order to understand by any new contributor?

@amands98
Copy link
Contributor

closing this PR, since it no longer required. // @Vad1mo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants