Fixes installation on MacOS on Apple Sillicon #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wouterdebie
commented
Apr 19, 2024
wouterdebie
commented
- Bumps py-cpuinfo to version 9
- Since there are no precompiled llama-cpp-python wheels available for MacOS on Apple Sillicon, this installs direclty from pypiy.org
gokayfem
reviewed
Apr 19, 2024
|
I'm a total noob when it comes to ComfyUI. What exactly do you want me to do? And how do I measure the startup time? |
|
when you start comfyui it gives you loading time for each node in the command line next to nodes |
|
Gotcha! |
|
thanks, i will check for windows and linux and after that i will merge. |
|
Great! If things are slow on Windows, I could make the version conditional. |
|
py-cpuinfo version 9 is slowing down loading time about 1.1 second on Windows. |
- Bumps py-cpuinfo to version 9 for arm64, but keeps version 3 for x86_x64 due performance concerns. - Since there are no precompiled llama-cpp-python wheels available for MacOS on Apple Sillicon, this installs direclty from pypiy.org.
|
I just pushed a new version that differentiates between arm64 and x86_64. Hope this works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.