feat: teach drawbox additional options
#1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the pattern established by Ranger's `draw_borders` setting: - `true` / `both`: draw an outline box around all panes, plus vertical separators between panes. - `outline`: draw only the outline box. - `separators`: draw only the separators. - `false` / `none`: draw neither outline box nor separators (default). So, this is a string option that accepts "true" and "false" strings for backwards compatibility. Note the behavior of toggling with `:set drawbox!`: if any borders are being drawn (ie. "both", "outline" or "separators", turns them off; if no borders are being drawn (ie. "none"), turns them all on (ie. "both"). Closes: gokcehan#1438
Because the "false" option is only there for backwards compatibility (drawbox used to be a boolean option).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the pattern established by Ranger's
draw_borderssetting:true/both: draw an outline box around all panes, plus vertical separators between panes.outline: draw only the outline box.separators: draw only the separators.false/none: draw neither outline box nor separators (default).So, this is a string option that accepts "true" and "false" strings for backwards compatibility.
Note the behavior of toggling with
:set drawbox!: if any borders are being drawn (ie. "both", "outline" or "separators", turns them off; if no borders are being drawn (ie. "none"), turns them all on (ie. "both").Closes: #1438
Context: I'm not a Go expert and I'm new to this codebase, so this is my first PR, so any and all feedback is welcome.