Removed testing for delegates in different running modes from iOS Vision Tasks #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired in iOS image classifier
| withCode:MPPTasksErrorCodeFailedPreconditionError | ||
| description:[NSString | ||
| stringWithFormat:@"This method can only be called if the task is " | ||
| @"running in a stream mode and an object of a class " |
There was a problem hiding this comment.
"an object of a class" is a bit hard to parse. Maybe just "and a delegate is provided in the task options..."
| @@ -59,7 +62,20 @@ - (instancetype)initWithCalculatorGraphConfig:(CalculatorGraphConfig)graphConfig | |||
| } | |||
|
|
|||
| - (BOOL)sendPacketMap:(const PacketMap &)packetMap error:(NSError **)error { | |||
| if (!_initializedWithPacketsCallback) { | |||
There was a problem hiding this comment.
This now means that we can initialize a task that will only ever throw errors. Is it possible to revert to the old behavior and throw an error on the initialization?
There was a problem hiding this comment.
Yeah, but then this whole change is unnecessary right? I mean wouldn't it suffice to just make all the delegate methods @required. Can I close this PR ?
There was a problem hiding this comment.
Probably. I think we can have @required methods and tests that the delegate object is set itself (like I believe we do today).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.