Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vi: block-n-scopes/...md translations #2073

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

vi: block-n-scopes/...md translations #2073

wants to merge 10 commits into from
+29 −8

Conversation

HuyNVuong
Copy link
Contributor

No description provided.

vohoanglong0107
vohoanglong0107 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@vohoanglong0107 vohoanglong0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation is really good, just left a few comment on some portion to make the translation clearer.

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po

#: src/control-flow-basics/blocks-and-scopes/scopes.md
msgid "\"inner scope: {a}\""
msgstr ""
msgstr "\"phạm vi bên trong: {a}\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this. What do you think @daivinhtran

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
@HuyNVuong HuyNVuong requested a review from qu-ngx as a code owner May 31, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vohoanglong0107 vohoanglong0107 vohoanglong0107 left review comments

@daivinhtran daivinhtran Awaiting requested review from daivinhtran daivinhtran is a code owner

@qu-ngx qu-ngx Awaiting requested review from qu-ngx qu-ngx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
translation/vi translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HuyNVuong @vohoanglong0107