A new stream-based Panic API #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
requested review from
romainguy,
z3moon,
elizagamedev,
bejado and
poweifeng
bejado
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM. Just an observation: if a user does this:
FILAMENT_CHECK_POSTCONDITION(false);
Then we get an empty "reason" string. I wonder if there's a way we can require users to provide a message (if we even want to require it) at compile time. Or, maybe we could provide a default message.
pixelflinger
force-pushed
the
ma/new-panic
branch
from
28e81ac
to
a0a7dcf
Compare
poweifeng
approved these changes
May 21, 2024
pixelflinger
force-pushed
the
ma/new-panic
branch
from
a0a7dcf
to
1e1d717
Compare
bejado
approved these changes
May 22, 2024
interesting idea. I think we probably can provide the stringified condition. I will give it a shot. |
going forward, instead of using the printf style syntax for panics we use the c++ stream syntax The new macros that replace ASSERT_*CONDITON are FILAMENT_CHECK_PRECONDITON FILAMENT_CHECK_POSTCONDITION FILAMENT_CHECK_ARITIHMETIC Example usage: FILAMENT_CHECK_PRECONDITON(condition) << "Message"; It's also now possible to define FILAMENT_PANIC_USES_ABSL=1 to redirect all these calls to Abseil's CHECK() macro.
pixelflinger
force-pushed
the
ma/new-panic
branch
from
1e1d717
to
f1378ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
going forward, instead of using the printf style syntax for panics we use the c++ stream syntax
The new macros that replace ASSERT_*CONDITON are
FILAMENT_CHECK_PRECONDITON
FILAMENT_CHECK_POSTCONDITION
FILAMENT_CHECK_ARITIHMETIC
Example usage:
FILAMENT_CHECK_PRECONDITON(condition) << "Message";
The effect is exactly the same as before, but it'll let clients use Abseil's logging facilities.