Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talking Character: fix copy mediapipe to a wrong directory #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hiwei93
Copy link
Contributor

@hiwei93 hiwei93 commented May 28, 2023

In npm strat script command, there is an error: copying scripts in third_party/mediapipe/ to a wrong directory ./src/apis/

In file src/apis/mediapipe_audio_blendshapes.ts, importing createMediaPipeLib from path ./mediapipe/web/graph_runner/graph_runner, so yarn start or npm start will be failed.

Fix this issue by copying scripts in third_party/mediapipe/ to the directory ./src/apis/mediapipe/

@markmcd markmcd requested review from jayjicheng and lyleaf May 29, 2023 06:08
@markmcd
Copy link
Member

markmcd commented May 29, 2023

I think this is related to the talking_character demo app, so adding Jay & Yiling.

@markmcd markmcd changed the title fix copy mediapipe to a wrong directory Talking Character: fix copy mediapipe to a wrong directory May 29, 2023
@hiwei93
Copy link
Contributor Author

hiwei93 commented May 29, 2023

I accidentally added a new commit to this pull request. And I don't know how to cancel it. 😂

I am not sure if it's ok to merge those two commits in one pull request.

@markmcd
Copy link
Member

markmcd commented May 30, 2023

I accidentally added a new commit to this pull request. And I don't know how to cancel it. joy

You can force push a branch/PR. You should be able to do something like git reset --hard HEAD^ (from the checked-out branch) to delete the last commit, then git push --force to update the PR.

Beware though, I have not tested these commands, so take a backup :)

@hiwei93
Copy link
Contributor Author

hiwei93 commented May 30, 2023

I accidentally added a new commit to this pull request. And I don't know how to cancel it. joy

You can force push a branch/PR. You should be able to do something like git reset --hard HEAD^ (from the checked-out branch) to delete the last commit, then git push --force to update the PR.

Beware though, I have not tested these commands, so take a backup :)

Thanks, I change it back. 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:demos Update demos demos:talking-character status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants