Glome server example #57
Conversation
pedrobn23
force-pushed
the
pedrobn23/go-glome-server-example
branch
from
0be30f2
to
34c63e5
Compare
pedrobn23
force-pushed
the
pedrobn23/go-glome-server-example
branch
9 times, most recently
from
f24bccd
to
72755be
Compare
| fmt.Println(`Please, provide key file, authorization script and address. | ||
| For more information read --help option.`) | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
There's a mechanism for enforcing flag presence, https://github.com/spf13/cobra#required-flags. If you still need to do more complicated sanity checks (cross-deps between flags, for example), you can do that check in a PreRunE: https://github.com/spf13/cobra#prerun-and-postrun-hooks.
There was a problem hiding this comment.
I'd use a PreRunE that returns an error with that message. That would automatically terminate the process with a non-zero exit code.
pedrobn23
force-pushed
the
pedrobn23/go-glome-server-example
branch
3 times, most recently
from
cc1205b
to
a084525
Compare
burgerdev
force-pushed
the
pedrobn23/go-glome-server-example
branch
3 times, most recently
from
70af180
to
8abcfd0
Compare
Implements an example of use of glome server framework. This example of use is a binary with cobra interface and support different configurations Signed-off-by: pedrobn <pedrobn@google.com>
burgerdev
force-pushed
the
pedrobn23/go-glome-server-example
branch
from
8abcfd0
to
8b27bc5
Compare
| fmt.Println(`Please, provide key file, authorization script and address. | ||
| For more information read --help option.`) | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
I'd use a PreRunE that returns an error with that message. That would automatically terminate the process with a non-zero exit code.
| cmd := exec.Command(p) | ||
| cmd.Stdin = nil | ||
| cmd.Env = []string{ | ||
| fmt.Sprintf("USER=%s", user), |
There was a problem hiding this comment.
The env vars used for configuration should avoid conflicts, a list of names that already have meaning can be found here: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html. IT might be a good idea to use a GLOME_AUTHZ_ prefix or similar.
| if err == nil { | ||
| return true, nil | ||
| } else { | ||
| return false, nil |
There was a problem hiding this comment.
Should return the error message (authz binary stderr).
| } else { | ||
| os.Exit(1) | ||
| } | ||
| } |
There was a problem hiding this comment.
Leftover, is superseded by authorization.sh.
| TOKEN=`curl -s 127.0.0.1:8000/v1/UYcvQ1u4uJ0OOtYqouURB07hleHDnvaogAFBi-ZW48N2/serial-number:1234567890=ABCDFGH%2F%23%3F/reboot/` | ||
| if [[ "$TOKEN" != "p8M_BUKj7zXBVM2JlQhNYFxs4J-DzxRAps83ZaNDquY=" ]] | ||
| then | ||
| kill $ID |
There was a problem hiding this comment.
This test should report the HTTP code and the return body in case != 200. In the 200 case, it should output the returned token if it does not match.
Example implementation of glome server