-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/translations: add a notice at the end of each translated document #4650
base: master
Are you sure you want to change the base?
Conversation
@a-nogikh please take a look at this PR. |
Hmm, interesting, looks like we have some trouble with non-ascii characters here: syzkaller/tools/check-whitespace.sh Lines 9 to 13 in f323435
|
How do I handle this PR to bypass the CI checker? |
We need to fix the checker, but I haven't yet figured out how. |
A quick question: why does the previous translation of program_syntax.md bypass the CI? It should also have the empty line before the last notice? This is wired. |
Does it work if you do add a line break at the end of your It goes somewhat against the error message, but the checker script ( |
It seems not working. |
It is great to add a notice at the end of each translated document to remind readers that, this is a community-driven translation of the official syzkaller documentation. Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
I think it actually worked. Now it reports a different error:
And I do indeed see whitespaces at the end of those two lines where it fired. |
Let me use a clean PR to complete this translation submission. |
I remembered what's going on there. I intentionally added two spaces at the end of that line and remove that empty line to make the ci happy. However, the ci reported the issue in the line with two spaces adding in the end. You can take a look at the similar issue in which the commit is rebased on the master branch and trigger the ci again. The ci still reports the old problem. |
It is great to add a notice at the end of each translated document to remind readers that, this is a community-driven translation of the official syzkaller documentation.