Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the dev server for the Lite E2E test instead of the built version… #8031

Closed
wants to merge 9 commits into from

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Apr 15, 2024

… so we can see more informative logs when an error occurs

Description

Error logs and stack trace on the built and minified files are not good for debugging.

… so we can see more informative logs when an error occurs
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook failed! Details
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/27d4742770755ba7cbe582fd163f431226662b26/gradio-4.28.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@27d4742770755ba7cbe582fd163f431226662b26#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
@gradio/tootils minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Use the dev server for the Lite E2E test instead of the built version…

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx
Copy link
Member Author

whitphx commented Apr 19, 2024

This PR makes the functional test take +20mis, which is not acceptable...
Will keep the CI as-is, and add this dev-server mode as an option for local dev.

The original problem behind this issue was solved without running the dev-server, so will close this PR at this moment.
Will refer to this code when it becomes necessary.

@whitphx whitphx closed this May 2, 2024
@whitphx whitphx deleted the lite-e2e-dev-server branch May 2, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants