fix: handling SIGINT correctly in reload.py, single entrance of block_thread in blocks.py #8158
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/b4df5fb40974197d5d41277e2627b559de7d6a77/gradio-4.28.3-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b4df5fb40974197d5d41277e2627b559de7d6a77#subdirectory=client/python" |
gradio/cli/commands/reload.py
Outdated
| try: | ||
| popen.wait() | ||
| except (KeyboardInterrupt, OSError): | ||
| print("gradio-cli: Waiting gradio main thread cleaning.") |
There was a problem hiding this comment.
Hi @Tiger3018 ! This contribution looks good to me but I don't think we need print statement here
There was a problem hiding this comment.
In the original implementation, the typer module will print Aborted! (See this line in typer module) and silently exit. This PR will remove the Aborted! echo and I don't know if an alternative text should be there.
Maybe we should just follow the implementation of gradio module, and use pass in this line instead?
There was a problem hiding this comment.
Yes, pass is what I had in mind
There was a problem hiding this comment.
Pushed that up so we can merge this in. Thanks!
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…_thread in blocks.py (#8158) * fix: handling SIGINT, single block_thread and fix popen * Use pass --------- Co-authored-by: freddyaboulton <alfonsoboulton@gmail.com>
Description
Closes: #8157