Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hatch installation in js/app/package.json which is no longer needed #8174

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Apr 30, 2024

Description

Delete a snippet which was added in #7855 to make the test pass in a non-main branch.
It's no longer needed as the PR was merged.

@whitphx whitphx changed the title Remove hatch installation in js/app/package.json which is no longer n… Remove hatch installation in js/app/package.json which is no longer needed Apr 30, 2024
@whitphx whitphx added the v: patch A change that requires a patch release label Apr 30, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 30, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/93c4fbfbc6e6704fbcfc55aa54d8716e977a296b/gradio-4.28.3-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@93c4fbfbc6e6704fbcfc55aa54d8716e977a296b#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Apr 30, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Remove hatch installation in js/app/package.json which is no longer needed

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx force-pushed the fix/revert-hatch-installation branch from ee5baab to b8fee35 Compare April 30, 2024 07:40
@whitphx whitphx marked this pull request as ready for review April 30, 2024 07:54
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @whitphx !

@whitphx
Copy link
Member Author

whitphx commented Apr 30, 2024

UI test fails with a weird diff 👀
CleanShot 2024-04-30 at 18 25 34@2x

@pngwn
Copy link
Member

pngwn commented Apr 30, 2024

This is just flake. It takes a second for the preview panel to render. You can approve it and move on. We need to figure out some of the flake in the visual tests.

@whitphx whitphx merged commit a81e369 into main Apr 30, 2024
8 checks passed
@whitphx whitphx deleted the fix/revert-hatch-installation branch April 30, 2024 22:45
@pngwn pngwn mentioned this pull request Apr 30, 2024
freddyaboulton pushed a commit that referenced this pull request May 2, 2024
…eeded (#8174)

* Remove hatch installation in js/app/package.json which is no longer needed

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
dawoodkhan82 pushed a commit that referenced this pull request May 6, 2024
…eeded (#8174)

* Remove hatch installation in js/app/package.json which is no longer needed

* add changeset

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants