Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce order between tasks to avoid flakiness #29165

Merged
merged 2 commits into from
May 20, 2024
Merged

Enforce order between tasks to avoid flakiness #29165

merged 2 commits into from
May 20, 2024

Conversation

abstratt
Copy link
Member

...which was reproducible with the CC executer.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@abstratt abstratt added a:chore Minor issue without significant impact p:flaky-fix-it labels May 15, 2024
@abstratt abstratt added this to the 8.9 RC1 milestone May 15, 2024
@abstratt abstratt self-assigned this May 15, 2024
@abstratt abstratt requested a review from a team as a code owner May 15, 2024 18:51
@abstratt abstratt force-pushed the rchaves/master/fix-flakiness-overlapping-outputs branch from 5f549d4 to 17a0fdd Compare May 15, 2024 19:01
@abstratt
Copy link
Member Author

@bot-gradle test ACC

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@abstratt
Disable parallel task execution
c0f6129 
...as tests rely on order
@abstratt abstratt force-pushed the rchaves/master/fix-flakiness-overlapping-outputs branch from 17a0fdd to c0f6129 Compare May 15, 2024 20:20
@gitstream-cm gitstream-cm bot removed the a:chore Minor issue without significant impact label May 15, 2024
@abstratt
Enforce max-workers=1 for all test cases
558e3ce 
so they run deterministically across all runners, and we avoid flakiness.
@abstratt
Copy link
Member Author

@bot-gradle test ACC

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@abstratt abstratt added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 0feef83 May 20, 2024
32 checks passed
@abstratt abstratt deleted the rchaves/master/fix-flakiness-overlapping-outputs branch May 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blindpirate blindpirate blindpirate approved these changes

Assignees

@abstratt abstratt

Labels
p:flaky-fix-it
Projects
None yet
Milestone
8.9 RC1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abstratt @bot-gradle @blindpirate