Support for rule based declarative conventions #29191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not properly apply dependency conventions yet.
ghale
force-pushed
the
gh/declarative/convention-rules
branch
from
f5585e5
to
e86456e
Compare
h0tk3y
reviewed
May 17, 2024
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
...vider/src/main/kotlin/org/gradle/internal/declarativedsl/software/schemaFromSoftwareTypes.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/org/gradle/internal/declarativedsl/conventions/ConventionsResolutionProcessor.kt
Outdated
Show resolved
Hide resolved
...vider/src/main/kotlin/org/gradle/internal/declarativedsl/software/schemaFromSoftwareTypes.kt
Outdated
Show resolved
Hide resolved
h0tk3y
reviewed
May 17, 2024
.../main/kotlin/org/gradle/internal/declarativedsl/project/ProjectInterpretationSequenceStep.kt
Outdated
Show resolved
Hide resolved
h0tk3y
reviewed
May 17, 2024
.../main/kotlin/org/gradle/internal/declarativedsl/project/ProjectInterpretationSequenceStep.kt
Outdated
Show resolved
Hide resolved
Any code that does not create schema type instances should be compatible with TAPI proxies implementing the schema interfaces, so it should not depend on the implementation types.
ghale
changed the title
It does not need to check each nested statement if it has `isTopLevelElement().implies(...)`.
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
h0tk3y
approved these changes
May 21, 2024
...sl-provider/src/main/kotlin/org/gradle/internal/declarativedsl/settings/SettingsDslSchema.kt
Outdated
Show resolved
Hide resolved
ghale
changed the title
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
|
The merge queue build has failed. Click here to see all failures. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for rule-based reusable conventions in build-level declarative dsl scripts.
Reviewing cheatsheet
Before merging the PR, comments starting with