Fix failing toolchain tests

[octylFractal]

Fixes https://github.com/gradle/gradle-private/issues/4195, fixes https://github.com/gradle/gradle-private/issues/4198, as well as additional issues with assertions failing when the current JDK matched the spec. These tests are now specifically designed to have a spec that will never match the current JDK.

Reviewing cheatsheet

Before merging the PR, comments starting with

• ❌ ❓must be fixed
• 🤔 💅 should be fixed
• 💭 may be fixed
• 🎉 celebrate happy things

[octylFractal]

@bot-gradle help

[bot-gradle]

Currently, the following commands are supported:

@bot-gradle test <BuildTrigger1> <BuildTrigger2> ... <BuildTriggerN> [without PTS]

Add without PTS to run the build with full test coverage.

• A trigger is a special build for this PR on TeamCity, common triggers are:
  • SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/PullRequestFeedback/ReadyForNightly/ReadyForRelease
  • Shortcuts: SC/CA/QFL/QF/PRF/RFN/RFR
  • Specific builds:
    • BD: BuildDistributions/BuildDocs so that you can preview the generated docs/distribution.
    • PT: PerformanceTest, all performance tests for Ready For Nightly stage.
    • APT: AllPerformanceTest, all performance tests, including slow performance tests.
    • AST: AllSmokeTestsPullRequestFeedback
    • AFT: AllFunctionalTestsPullRequestFeedback
    • ASB: AllSpecificBuildsPullRequestFeedback
    • ACC: AllConfigCacheTestsPullRequestFeedback
    • ACT: AllCrossVersionTestsReadyForNightly
    • AFTN: AllFunctionalTestsReadyForNightly
    • ACTR: AllCrossVersionTestsReadyForRelease
    • AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle squash

• Squash the current pull request into a single commit. The squash message will come from the pull request body, with:
  • All Signed-off-by: lines kept.
  • All authors being Co-Authored-By:

@bot-gradle merge

• Enqueue this PR into GitHub merge queue for merging.
  • GitHub will create a merge commit from your PR branch HEAD and the target branch
  • A GitHub Merge Queue Check Pass build will be triggered on the merge commit
  • When the build passes, the target branch will be fast-forwarded to this merge commit (i.e. merge the PR)

@bot-gradle squash and merge

• Squash the current pull request into a single commit as described in squash command above,
  then enqueue this PR into GitHub merge queue as described in merge command above.

@bot-gradle cherrypick to <branch>

• Cherrypicks the current PR to another branch.
  A new PR will be created and a build will triggered automatically if there is no conflict.

@bot-gradle cancel

• cancel a running build in GitHub merge queue and remove the PR from the queue

@bot-gradle clean

• clear the conversation history

@bot-gradle help

• display this message

To run a command, simply submit a comment. For detailed instructions see here.

[octylFractal]

@bot-gradle test AllCrossVersionTestsReadyForNightly AllSmokeTestsPullRequestFeedback

[bot-gradle]

I've triggered the following builds for you. Click here to see all build failures.

• AllCrossVersionTestsReadyForNightly build
• AllSmokeTestsPullRequestFeedback build

[bot-gradle]

The merge queue build has failed. Click here to see all failures.

[bot-gradle]

The merge queue build has failed. Click here to see all failures.