Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let GradleLifecycle callbacks preserve user code application context #29200

Merged

Conversation

bamboo
Copy link
Member

@bamboo bamboo commented May 17, 2024

Context

The user code application context is required for proper attribution in reports and build scans.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@bamboo bamboo added a:feature A new functionality in:configuration-model lazy api, domain object container 5 min review labels May 17, 2024
@bamboo bamboo added this to the 8.9 RC1 milestone May 17, 2024
@bamboo bamboo marked this pull request as ready for review May 17, 2024 14:50
@bamboo bamboo requested review from a team as code owners May 17, 2024 14:50
@bamboo bamboo requested review from abstratt and mlopatkin and removed request for a team May 17, 2024 14:50
@bamboo bamboo changed the base branch from master to release May 17, 2024 17:00
@bamboo bamboo requested review from a team, tresat and ldaley as code owners May 17, 2024 17:00
@bamboo bamboo removed the request for review from a team May 17, 2024 17:00
@bamboo bamboo removed request for a team, tresat, ldaley and ljacomet May 17, 2024 17:04
@bamboo bamboo added this pull request to the merge queue May 17, 2024
@bamboo bamboo modified the milestones: 8.9 RC1, 8.8 RC2 May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@bamboo
Copy link
Member Author

bamboo commented May 17, 2024

@bot-gradle test

@gradle gradle deleted a comment from bamboo May 17, 2024
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@bamboo bamboo force-pushed the bamboo/ip/lifecycle/preserve-user-code-application-context branch from 6169ea7 to 0475a24 Compare May 17, 2024 18:48
@gradle gradle deleted a comment from bot-gradle May 17, 2024
@gradle gradle deleted a comment from bot-gradle May 17, 2024
@bamboo bamboo added this pull request to the merge queue May 17, 2024
@bot-gradle
Copy link
Collaborator

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.

Merged via the queue into release with commit d12a856 May 17, 2024
42 checks passed
@bamboo bamboo deleted the bamboo/ip/lifecycle/preserve-user-code-application-context branch May 17, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:configuration-model lazy api, domain object container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants