Support sqlite builds with DQS=off #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sqlite3 is built with double-quoted string literals disabled (which is recommended, see https://www.sqlite.org/compile.html#dqs), diskcache starts failing with the following crypting error: ``` no such column: "size" ``` This is because the syntax `WHERE key = "size"` in standard SQL refers to a column named "size", not a string literal. Parsing this as a string literal is a conditional sqlite extension. This patch makes the code more robust by avoiding this optional sqlite feature.
|
cc @grantjenks |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 22, 2024
- grantjenks/python-diskcache#311 Differential Revision: https://reviews.freebsd.org/D45295 Approved by: yuri Sponsored by: SkunkWerks, GmbH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sqlite3 is built with double-quoted string literals disabled (which is recommended, see https://www.sqlite.org/compile.html#dqs), diskcache starts failing with the following crypting error:
This is because the syntax
WHERE key = "size"in standard SQL refers to a column named "size", not a string literal. Parsing this as a string literal is a conditional sqlite extension.This patch makes the code more robust by avoiding this optional sqlite feature.