smart dependency manager #511
Open
+315
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeyerov
reviewed
Oct 10, 2023
graphistry/dep_manager.py
Outdated
| self.pkgs = {} | ||
| self.deps() | ||
|
|
||
| def __getattr__(self, pkg): |
There was a problem hiding this comment.
added pkg:str here to return type; i dont think this is related to the pytest type check errors below and in #489.
but i also dont know why this arrow_uploader error is coming up
There was a problem hiding this comment.
any idea about this type check error, seemingly involving arrow_uploader? another PR pings this same error, not sure what to make of it
lmeyerov
reviewed
Oct 14, 2023
lmeyerov
reviewed
Oct 14, 2023
lmeyerov
reviewed
Oct 14, 2023
lmeyerov
reviewed
Oct 14, 2023
lmeyerov
reviewed
Oct 14, 2023
|
what's the reln of this w/ #517 ? |
merged it into 517 a while ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just needed to fix counterfactual of tanmoy's toy code, change order to fit into existing scheme, also add fourth variable for version