Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use unavailable identity verification methods when adding MFAs #41607

Merged
merged 1 commit into from
May 16, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented May 15, 2024

This change restricts the available identity verification methods to the ones that are configured in the user's account. It also provides error messaging for when no such method is available.

Note that the latter is an edge case that occurs only when the cluster configuration has been changed while the user was signed in, but nevertheless, it's possible.

Screenshot 2024-05-15 at 20 19 10 Screenshot 2024-05-15 at 20 17 27

Closes #23443

Tested:

  • Adding a passkey, having only a WebAuthn key
  • Adding a passkey, having only an authenticator app
  • Adding a WebAuthn key, having only a WebAuthn key
  • Adding a WebAuthn key, having only an authenticator app
  • Adding a WebAuthn key, having both methods available
  • Adding an authenticator app, having only a WebAuthn key
  • Adding an authenticator app, having only an authenticator app
  • Adding a WebAuthn key, having no eligible MFA method (OTP required)
  • Adding a WebAuthn key, having no eligible MFA method (WebAuthn required)

@bl-nero bl-nero added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 15, 2024
@bl-nero bl-nero added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@bl-nero bl-nero added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit 744d6d2 May 16, 2024
39 of 40 checks passed
@bl-nero bl-nero deleted the bl-nero/mfa-verification branch May 16, 2024 18:02
@public-teleport-github-review-bot

@bl-nero See the table below for backport results.

Branch Result
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better UX when adding MFA
3 participants