Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "--" arg for forwarding options in yarn scripts #41617

Merged
merged 1 commit into from
May 17, 2024
Merged

Remove "--" arg for forwarding options in yarn scripts #41617

merged 1 commit into from
May 17, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented May 15, 2024

This resolves a warning:

warning From Yarn 1.0 onwards, scripts don't require "--" for options to
be forwarded. In a future version, any explicit "--" will be forwarded
as-is to the scripts.

@zmb3
Remove "--" arg for forwarding options.
8268f37 
This resolves a warning:

    warning From Yarn 1.0 onwards, scripts don't require "--" for options to
    be forwarded. In a future version, any explicit "--" will be forwarded
    as-is to the scripts.
@github-actions github-actions bot requested review from jakule and Joerger May 15, 2024 20:05
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 changed the title Remove "--" arg for forwarding options. Remove "--" arg for forwarding options in yarn scripts May 15, 2024
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 added the no-changelog Indicates that a PR does not require a changelog entry label May 15, 2024
@zmb3 zmb3 requested a review from ravicious May 17, 2024 14:24
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from jakule May 17, 2024 15:17
@zmb3 zmb3 added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 6d6551e May 17, 2024
37 of 39 checks passed
@zmb3 zmb3 deleted the zmb3/snapshot-arg branch May 17, 2024 15:36
@public-teleport-github-review-bot
Copy link

@zmb3 See the table below for backport results.

Branch Result
branch/v14 Create PR
branch/v15 Create PR

This was referenced May 17, 2024
Merged
Merged
justinas pushed a commit that referenced this pull request May 20, 2024
@zmb3 @justinas
Remove "--" arg for forwarding options. (#41617)
72ab31e 
This resolves a warning:

    warning From Yarn 1.0 onwards, scripts don't require "--" for options to
    be forwarded. In a future version, any explicit "--" will be forwarded
    as-is to the scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravicious ravicious ravicious approved these changes

@Joerger Joerger Joerger approved these changes

Assignees
No one assigned
Labels
backport/branch/v14 backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmb3 @ravicious @Joerger