Replace dependencies on lib/auth with lib/authclient #41623

rosstimothy · 2024-05-15T21:49:05Z

Refactors code that was consuming lib/auth to use lib/auth/authclient instead. While this does touch a large number of files each commit is atomic and most commits are simply renaming types to use their equivalent in authclient. In addition to name changes this also moves some additional code from lib/auth to lib/auth/authclient.

Items moved to authclient

auth.HostFQDN: c6ed4b7
auth.WithClusterCAs, auth.DefaultClientCertPool, and auth.ClientCertPool: 38a602e
auth.TryCreateAppSessionForClientCertV15: de912f5
auth.ErrNoMFADevices: 6a2c286

Additionally, this also starts the migration of the AccessPoint interfaces defined in lib/auth/api.go into authclient. For the moment only lib/reversetunnelclient has been updated to consume interfaces from the new location. All other consumers will be migrated at a later time to reduce the size of this PR.

Dependency Tree

While this PR doesn't remove lib/auth from client tools dependency trees, it does have a significant reduction in the number of times it shows up in the tree.

master

$ goda tree "reach(github.com/gravitational/teleport/tool/tbot...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tbot
    ├ github.com/gravitational/teleport/lib/tbot
      ├ github.com/gravitational/teleport/lib/auth
      ├ github.com/gravitational/teleport/lib/client
        ├ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/srv/alpnproxy
          └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/client/identityfile
        ├ github.com/gravitational/teleport/lib/client ~
        └ github.com/gravitational/teleport/lib/kube/kubeconfig
          └ github.com/gravitational/teleport/lib/client ~
      ├ github.com/gravitational/teleport/lib/reversetunnelclient
        ├ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/proxy/peer
          └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/srv/alpnproxy ~
      └ github.com/gravitational/teleport/lib/tbot/config
        ├ github.com/gravitational/teleport/lib/auth ~
        ├ github.com/gravitational/teleport/lib/client ~
        ├ github.com/gravitational/teleport/lib/client/identityfile ~
        └ github.com/gravitational/teleport/lib/kube/kubeconfig ~
    ├ github.com/gravitational/teleport/lib/tbot/config ~
    └ github.com/gravitational/teleport/lib/tbot/tshwrap
      ├ github.com/gravitational/teleport/lib/client ~
      └ github.com/gravitational/teleport/lib/tbot/config ~


$ goda tree "reach(github.com/gravitational/teleport/tool/tctl...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tctl
    └ github.com/gravitational/teleport/tool/tctl/common
      ├ github.com/gravitational/teleport/lib/auth
      ├ github.com/gravitational/teleport/lib/auth/windows
        └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/client
        ├ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/srv/alpnproxy
          └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/client/db
        ├ github.com/gravitational/teleport/lib/auth ~
        ├ github.com/gravitational/teleport/lib/client ~
        └ github.com/gravitational/teleport/lib/client/identityfile
          ├ github.com/gravitational/teleport/lib/client ~
          └ github.com/gravitational/teleport/lib/kube/kubeconfig
            └ github.com/gravitational/teleport/lib/client ~
      ├ github.com/gravitational/teleport/lib/client/identityfile ~
      ├ github.com/gravitational/teleport/lib/config
        ├ github.com/gravitational/teleport/lib/client ~
        ├ github.com/gravitational/teleport/lib/pam
          └ github.com/gravitational/teleport/lib/service/servicecfg
            └ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/lib/reversetunnelclient
        ├ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/proxy/peer
          └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/common/accessmonitoring
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/common/loginrule
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/sso/configure
        ├ github.com/gravitational/teleport/lib/service/servicecfg ~
        └ github.com/gravitational/teleport/tool/tctl/sso/tester
          ├ github.com/gravitational/teleport/lib/auth ~
          ├ github.com/gravitational/teleport/lib/client ~
          └ github.com/gravitational/teleport/lib/service/servicecfg ~
      └ github.com/gravitational/teleport/tool/tctl/sso/tester ~


$ goda tree "reach(github.com/gravitational/teleport/tool/tsh...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tsh
    └ github.com/gravitational/teleport/tool/tsh/common
      ├ github.com/gravitational/teleport/lib/auth
      ├ github.com/gravitational/teleport/lib/benchmark
        ├ github.com/gravitational/teleport/lib/client
          ├ github.com/gravitational/teleport/lib/auth ~
          └ github.com/gravitational/teleport/lib/srv/alpnproxy
            └ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/web
          ├ github.com/gravitational/teleport/lib/auth ~
          ├ github.com/gravitational/teleport/lib/client ~
          ├ github.com/gravitational/teleport/lib/client/conntest
            ├ github.com/gravitational/teleport/lib/auth ~
            └ github.com/gravitational/teleport/lib/client ~
          ├ github.com/gravitational/teleport/lib/client/db
            ├ github.com/gravitational/teleport/lib/auth ~
            ├ github.com/gravitational/teleport/lib/client ~
            └ github.com/gravitational/teleport/lib/client/identityfile
              ├ github.com/gravitational/teleport/lib/client ~
              └ github.com/gravitational/teleport/lib/kube/kubeconfig
                └ github.com/gravitational/teleport/lib/client ~
          ├ github.com/gravitational/teleport/lib/client/identityfile ~
          ├ github.com/gravitational/teleport/lib/integrations/awsoidc/deployserviceconfig
            └ github.com/gravitational/teleport/lib/config
              ├ github.com/gravitational/teleport/lib/client ~
              ├ github.com/gravitational/teleport/lib/pam
                └ github.com/gravitational/teleport/lib/service/servicecfg
                  └ github.com/gravitational/teleport/lib/auth ~
              └ github.com/gravitational/teleport/lib/service/servicecfg ~
          ├ github.com/gravitational/teleport/lib/proxy
            └ github.com/gravitational/teleport/lib/reversetunnelclient
              ├ github.com/gravitational/teleport/lib/auth ~
              └ github.com/gravitational/teleport/lib/proxy/peer
                └ github.com/gravitational/teleport/lib/auth ~
          ├ github.com/gravitational/teleport/lib/reversetunnelclient ~
          ├ github.com/gravitational/teleport/lib/srv/desktop/tdp
            └ github.com/gravitational/teleport/lib/client ~
          ├ github.com/gravitational/teleport/lib/web/app
            ├ github.com/gravitational/teleport/lib/auth ~
            └ github.com/gravitational/teleport/lib/reversetunnelclient ~
          └ github.com/gravitational/teleport/lib/web/ui
            └ github.com/gravitational/teleport/lib/reversetunnelclient ~
      ├ github.com/gravitational/teleport/lib/benchmark/db
        ├ github.com/gravitational/teleport/lib/benchmark ~
        ├ github.com/gravitational/teleport/lib/client ~
        └ github.com/gravitational/teleport/lib/srv/alpnproxy ~
      ├ github.com/gravitational/teleport/lib/client ~
      ├ github.com/gravitational/teleport/lib/client/db ~
      ├ github.com/gravitational/teleport/lib/client/db/dbcmd
        ├ github.com/gravitational/teleport/lib/client ~
        └ github.com/gravitational/teleport/lib/client/db ~
      ├ github.com/gravitational/teleport/lib/client/db/oracle
        └ github.com/gravitational/teleport/lib/client ~
      ├ github.com/gravitational/teleport/lib/client/identityfile ~
      ├ github.com/gravitational/teleport/lib/client/kube
        └ github.com/gravitational/teleport/lib/client ~
      ├ github.com/gravitational/teleport/lib/kube/kubeconfig ~
      ├ github.com/gravitational/teleport/lib/srv/alpnproxy ~
      ├ github.com/gravitational/teleport/lib/srv/desktop/tdp ~
      └ github.com/gravitational/teleport/lib/teleterm
        ├ github.com/gravitational/teleport/lib/teleterm/apiserver
          ├ github.com/gravitational/teleport/lib/teleterm/apiserver/handler
            ├ github.com/gravitational/teleport/lib/client ~
            ├ github.com/gravitational/teleport/lib/teleterm/clusters
              ├ github.com/gravitational/teleport/lib/auth ~
              ├ github.com/gravitational/teleport/lib/client ~
              ├ github.com/gravitational/teleport/lib/client/db ~
              ├ github.com/gravitational/teleport/lib/client/db/dbcmd ~
              ├ github.com/gravitational/teleport/lib/client/kube ~
              ├ github.com/gravitational/teleport/lib/kube/kubeconfig ~
              └ github.com/gravitational/teleport/lib/teleterm/gateway
                ├ github.com/gravitational/teleport/lib/client ~
                ├ github.com/gravitational/teleport/lib/kube/kubeconfig ~
                └ github.com/gravitational/teleport/lib/srv/alpnproxy ~
            ├ github.com/gravitational/teleport/lib/teleterm/cmd
              ├ github.com/gravitational/teleport/lib/client/db/dbcmd ~
              ├ github.com/gravitational/teleport/lib/teleterm/clusters ~
              └ github.com/gravitational/teleport/lib/teleterm/gateway ~
            ├ github.com/gravitational/teleport/lib/teleterm/daemon
              ├ github.com/gravitational/teleport/lib/client ~
              ├ github.com/gravitational/teleport/lib/teleterm/clusters ~
              ├ github.com/gravitational/teleport/lib/teleterm/cmd ~
              ├ github.com/gravitational/teleport/lib/teleterm/gateway ~
              ├ github.com/gravitational/teleport/lib/teleterm/services/clientcache
                ├ github.com/gravitational/teleport/lib/client ~
                └ github.com/gravitational/teleport/lib/teleterm/clusters ~
              ├ github.com/gravitational/teleport/lib/teleterm/services/connectmycomputer
                ├ github.com/gravitational/teleport/lib/client ~
                └ github.com/gravitational/teleport/lib/teleterm/clusters ~
              └ github.com/gravitational/teleport/lib/teleterm/services/unifiedresources
                └ github.com/gravitational/teleport/lib/teleterm/clusters ~
            └ github.com/gravitational/teleport/lib/teleterm/gateway ~
          └ github.com/gravitational/teleport/lib/teleterm/daemon ~
        ├ github.com/gravitational/teleport/lib/teleterm/clusters ~
        └ github.com/gravitational/teleport/lib/teleterm/daemon ~

tross/auth_client

$ goda tree "reach(github.com/gravitational/teleport/tool/tbot...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tbot
    └ github.com/gravitational/teleport/lib/tbot
      └ github.com/gravitational/teleport/lib/auth

$ goda tree "reach(github.com/gravitational/teleport/tool/tctl...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tctl
    └ github.com/gravitational/teleport/tool/tctl/common
      ├ github.com/gravitational/teleport/lib/auth
      ├ github.com/gravitational/teleport/lib/auth/windows
        └ github.com/gravitational/teleport/lib/auth ~
      ├ github.com/gravitational/teleport/lib/config
        ├ github.com/gravitational/teleport/lib/pam
          └ github.com/gravitational/teleport/lib/service/servicecfg
            └ github.com/gravitational/teleport/lib/auth ~
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/common/accessmonitoring
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/common/loginrule
        └ github.com/gravitational/teleport/lib/service/servicecfg ~
      ├ github.com/gravitational/teleport/tool/tctl/sso/configure
        ├ github.com/gravitational/teleport/lib/service/servicecfg ~
        └ github.com/gravitational/teleport/tool/tctl/sso/tester
          └ github.com/gravitational/teleport/lib/service/servicecfg ~
      └ github.com/gravitational/teleport/tool/tctl/sso/tester ~

$ goda tree "reach(github.com/gravitational/teleport/tool/tsh...:all, github.com/gravitational/teleport/lib/auth)"
  ├ github.com/gravitational/teleport/tool/tsh
    └ github.com/gravitational/teleport/tool/tsh/common
      ├ github.com/gravitational/teleport/lib/auth
      ├ github.com/gravitational/teleport/lib/benchmark
        └ github.com/gravitational/teleport/lib/web
          ├ github.com/gravitational/teleport/lib/auth ~
          ├ github.com/gravitational/teleport/lib/integrations/awsoidc/deployserviceconfig
            └ github.com/gravitational/teleport/lib/config
              ├ github.com/gravitational/teleport/lib/pam
                └ github.com/gravitational/teleport/lib/service/servicecfg
                  └ github.com/gravitational/teleport/lib/auth ~
              └ github.com/gravitational/teleport/lib/service/servicecfg ~
          └ github.com/gravitational/teleport/lib/web/app
            └ github.com/gravitational/teleport/lib/auth ~
      └ github.com/gravitational/teleport/lib/benchmark/db
        └ github.com/gravitational/teleport/lib/benchmark ~

Important

Depends on https://github.com/gravitational/teleport.e/pull/4174 - removal of authclient aliases here will break e builds if this merges first.

rosstimothy · 2024-05-15T23:17:53Z

lib/auth/api.go

Aliases were left behind here to prevent breaking e and limit further changes to this PR. I'll convert consumers to use the new types in authclient in a follow up.

tigrato

rosstimothy · 2024-05-16T15:20:12Z

/excludeflake *

zmb3 · 2024-05-16T16:29:32Z

/excludeflake *

…ertPool to authclient

…yAccessPoint

…dependency

…event breaking builds

public-teleport-github-review-bot · 2024-05-16T17:52:32Z

@rosstimothy See the table below for backport results.

Branch	Result
branch/v14	Failed
branch/v15	Failed

* Remove authclient.Client/ClientI/NewClient aliases in lib/auth * Remove WebSessionReq aliases in lib/auth * Remove GithubAuthResponse aliases in lib/auth * Remove GithubAuthRequest aliases in lib/auth * Remove KubeCSR alias in lib/auth * Remove KubeCSRResponse alias in lib/auth * Remove OIDCAuthResponse alias in lib/auth * Remove OIDCAuthRequest alias in lib/auth * Remove ValidateOIDCAuthCallbackReq alias in lib/auth * Remove OIDCAuthRawResponse alias in lib/auth * Remove CreateUserTokenRequest alias in lib/auth * Remove SAMLAuthResponse alias in lib/auth * Remove SAMLAuthRequest alias in lib/auth * Remove ValidateSAMLResponseReq alias in lib/auth * Remove SAMLAuthRawResponse alias in lib/auth * Remove ValidateTrustedClusterRequest alias in lib/auth * Remove ValidateTrustedClusterRequestRaw alias in lib/auth * Remove ValidateTrustedClusterResponse alias in lib/auth * Remove ValidateTrustedClusterResponseRaw alias in lib/auth * Remove AuthenticateUserRequest alias in lib/auth * Remove ForwardedClientMetadata alias in lib/auth * Remove PassCreds alias in lib/auth * Remove OTPCreds alias in lib/auth * Remove SessionCreds alias in lib/auth * Remove AuthenticateSSHRequest alias in lib/auth * Remove SSHLoginResponse alias in lib/auth * Remove TrustedCerts alias in lib/auth * Remove AuthoritiesToTrustedCerts alias in lib/auth * Move auth.HostFQDN to authclient * Move auth.WithClusterCAs, auth.DefaultClientCertPool and auth.ClientCertPool to authclient * Switch alpn proxy to use authclient.CAGetter instead of auth.ReadProxyAccessPoint * Use a smaller scoped interfaces in lib/proxy/peer to remove lib/auth dependency * Move auth.TryCreateAppSessionForClientCertV15 to authclient * Move auth.ErrNoMFADevices to authclient * Move access point interfaces to authclient. Aliases left behind to prevent breaking builds * remove lib/auth dependency from lib/reversetunnelclient * fix lints * fix license * Bump e ref to include gravitational/teleport.e#4174 * Use authclient.Client in new tctl diag commands * Stop using auth.UserTokenType aliases

* Replace dependencies on lib/auth with lib/authclient (#41623) * Remove authclient.Client/ClientI/NewClient aliases in lib/auth * Remove WebSessionReq aliases in lib/auth * Remove GithubAuthResponse aliases in lib/auth * Remove GithubAuthRequest aliases in lib/auth * Remove KubeCSR alias in lib/auth * Remove KubeCSRResponse alias in lib/auth * Remove OIDCAuthResponse alias in lib/auth * Remove OIDCAuthRequest alias in lib/auth * Remove ValidateOIDCAuthCallbackReq alias in lib/auth * Remove OIDCAuthRawResponse alias in lib/auth * Remove CreateUserTokenRequest alias in lib/auth * Remove SAMLAuthResponse alias in lib/auth * Remove SAMLAuthRequest alias in lib/auth * Remove ValidateSAMLResponseReq alias in lib/auth * Remove SAMLAuthRawResponse alias in lib/auth * Remove ValidateTrustedClusterRequest alias in lib/auth * Remove ValidateTrustedClusterRequestRaw alias in lib/auth * Remove ValidateTrustedClusterResponse alias in lib/auth * Remove ValidateTrustedClusterResponseRaw alias in lib/auth * Remove AuthenticateUserRequest alias in lib/auth * Remove ForwardedClientMetadata alias in lib/auth * Remove PassCreds alias in lib/auth * Remove OTPCreds alias in lib/auth * Remove SessionCreds alias in lib/auth * Remove AuthenticateSSHRequest alias in lib/auth * Remove SSHLoginResponse alias in lib/auth * Remove TrustedCerts alias in lib/auth * Remove AuthoritiesToTrustedCerts alias in lib/auth * Move auth.HostFQDN to authclient * Move auth.WithClusterCAs, auth.DefaultClientCertPool and auth.ClientCertPool to authclient * Switch alpn proxy to use authclient.CAGetter instead of auth.ReadProxyAccessPoint * Use a smaller scoped interfaces in lib/proxy/peer to remove lib/auth dependency * Move auth.TryCreateAppSessionForClientCertV15 to authclient * Move auth.ErrNoMFADevices to authclient * Move access point interfaces to authclient. Aliases left behind to prevent breaking builds * remove lib/auth dependency from lib/reversetunnelclient * fix lints * fix license * Bump e ref to include gravitational/teleport.e#4174 * Use authclient.Client in new tctl diag commands * Stop using auth.UserTokenType aliases * Update e to include gravitational/teleport.e#4198 * fix: tests

* Replace dependencies on lib/auth with lib/authclient (#41623) * Remove authclient.Client/ClientI/NewClient aliases in lib/auth * Remove WebSessionReq aliases in lib/auth * Remove GithubAuthResponse aliases in lib/auth * Remove GithubAuthRequest aliases in lib/auth * Remove KubeCSR alias in lib/auth * Remove KubeCSRResponse alias in lib/auth * Remove OIDCAuthResponse alias in lib/auth * Remove OIDCAuthRequest alias in lib/auth * Remove ValidateOIDCAuthCallbackReq alias in lib/auth * Remove OIDCAuthRawResponse alias in lib/auth * Remove CreateUserTokenRequest alias in lib/auth * Remove SAMLAuthResponse alias in lib/auth * Remove SAMLAuthRequest alias in lib/auth * Remove ValidateSAMLResponseReq alias in lib/auth * Remove SAMLAuthRawResponse alias in lib/auth * Remove ValidateTrustedClusterRequest alias in lib/auth * Remove ValidateTrustedClusterRequestRaw alias in lib/auth * Remove ValidateTrustedClusterResponse alias in lib/auth * Remove ValidateTrustedClusterResponseRaw alias in lib/auth * Remove AuthenticateUserRequest alias in lib/auth * Remove ForwardedClientMetadata alias in lib/auth * Remove PassCreds alias in lib/auth * Remove OTPCreds alias in lib/auth * Remove SessionCreds alias in lib/auth * Remove AuthenticateSSHRequest alias in lib/auth * Remove SSHLoginResponse alias in lib/auth * Remove TrustedCerts alias in lib/auth * Remove AuthoritiesToTrustedCerts alias in lib/auth * Move auth.HostFQDN to authclient * Move auth.WithClusterCAs, auth.DefaultClientCertPool and auth.ClientCertPool to authclient * Switch alpn proxy to use authclient.CAGetter instead of auth.ReadProxyAccessPoint * Use a smaller scoped interfaces in lib/proxy/peer to remove lib/auth dependency * Move auth.TryCreateAppSessionForClientCertV15 to authclient * Move auth.ErrNoMFADevices to authclient * Move access point interfaces to authclient. Aliases left behind to prevent breaking builds * remove lib/auth dependency from lib/reversetunnelclient * fix lints * fix license * Bump e ref to include gravitational/teleport.e#4174 * Use authclient.Client in new tctl diag commands * Stop using auth.UserTokenType aliases * Update e to include gravitational/teleport.e#4197 * fix: tests

* Remove authclient.Client/ClientI/NewClient aliases in lib/auth * Remove WebSessionReq aliases in lib/auth * Remove GithubAuthResponse aliases in lib/auth * Remove GithubAuthRequest aliases in lib/auth * Remove KubeCSR alias in lib/auth * Remove KubeCSRResponse alias in lib/auth * Remove OIDCAuthResponse alias in lib/auth * Remove OIDCAuthRequest alias in lib/auth * Remove ValidateOIDCAuthCallbackReq alias in lib/auth * Remove OIDCAuthRawResponse alias in lib/auth * Remove CreateUserTokenRequest alias in lib/auth * Remove SAMLAuthResponse alias in lib/auth * Remove SAMLAuthRequest alias in lib/auth * Remove ValidateSAMLResponseReq alias in lib/auth * Remove SAMLAuthRawResponse alias in lib/auth * Remove ValidateTrustedClusterRequest alias in lib/auth * Remove ValidateTrustedClusterRequestRaw alias in lib/auth * Remove ValidateTrustedClusterResponse alias in lib/auth * Remove ValidateTrustedClusterResponseRaw alias in lib/auth * Remove AuthenticateUserRequest alias in lib/auth * Remove ForwardedClientMetadata alias in lib/auth * Remove PassCreds alias in lib/auth * Remove OTPCreds alias in lib/auth * Remove SessionCreds alias in lib/auth * Remove AuthenticateSSHRequest alias in lib/auth * Remove SSHLoginResponse alias in lib/auth * Remove TrustedCerts alias in lib/auth * Remove AuthoritiesToTrustedCerts alias in lib/auth * Move auth.HostFQDN to authclient * Move auth.WithClusterCAs, auth.DefaultClientCertPool and auth.ClientCertPool to authclient * Switch alpn proxy to use authclient.CAGetter instead of auth.ReadProxyAccessPoint * Use a smaller scoped interfaces in lib/proxy/peer to remove lib/auth dependency * Move auth.TryCreateAppSessionForClientCertV15 to authclient * Move auth.ErrNoMFADevices to authclient * Move access point interfaces to authclient. Aliases left behind to prevent breaking builds * remove lib/auth dependency from lib/reversetunnelclient * fix lints * fix license * Bump e ref to include gravitational/teleport.e#4174 * Use authclient.Client in new tctl diag commands * Stop using auth.UserTokenType aliases

rosstimothy force-pushed the tross/auth_client branch from 6f2b00f to c71b48b Compare May 15, 2024 23:14

rosstimothy commented May 15, 2024

View reviewed changes

rosstimothy added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 15, 2024

rosstimothy marked this pull request as ready for review May 16, 2024 00:22

github-actions bot requested review from fspmarshall, greedy52, marcoandredinis, tigrato and timothyb89 May 16, 2024 00:23

github-actions bot added application-access database-access Database access related issues and PRs kubernetes-access machine-id size/md tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels May 16, 2024

marcoandredinis approved these changes May 16, 2024

View reviewed changes

tigrato approved these changes May 16, 2024

View reviewed changes

public-teleport-github-review-bot bot removed request for timothyb89, greedy52 and fspmarshall May 16, 2024 08:38

rosstimothy force-pushed the tross/auth_client branch from 46d6c06 to fc916a1 Compare May 16, 2024 14:43

rosstimothy force-pushed the tross/auth_client branch from bad8ac3 to 94bf7da Compare May 16, 2024 16:40

rosstimothy enabled auto-merge May 16, 2024 16:43

rosstimothy disabled auto-merge May 16, 2024 16:43

rosstimothy force-pushed the tross/auth_client branch from 94bf7da to 604969e Compare May 16, 2024 16:48

rosstimothy added 14 commits May 16, 2024 12:48

Remove AuthoritiesToTrustedCerts alias in lib/auth

199fbb3

Move auth.HostFQDN to authclient

2f5464d

Move auth.WithClusterCAs, auth.DefaultClientCertPool and auth.ClientC…

fdb8eec

…ertPool to authclient

Switch alpn proxy to use authclient.CAGetter instead of auth.ReadProx…

8ba1dd3

…yAccessPoint

Use a smaller scoped interfaces in lib/proxy/peer to remove lib/auth …

e800b78

…dependency

Move auth.TryCreateAppSessionForClientCertV15 to authclient

58f08e4

Move auth.ErrNoMFADevices to authclient

92ba82c

Move access point interfaces to authclient. Aliases left behind to pr…

5b2dadc

…event breaking builds

remove lib/auth dependency from lib/reversetunnelclient

25fd981

fix lints

8a59659

fix license

53aa328

Bump e ref to include gravitational/teleport.e#4174

2c335a2

Use authclient.Client in new tctl diag commands

28d0607

Stop using auth.UserTokenType aliases

ae6ade8

rosstimothy force-pushed the tross/auth_client branch from 604969e to ae6ade8 Compare May 16, 2024 16:49

rosstimothy enabled auto-merge May 16, 2024 16:49

rosstimothy added this pull request to the merge queue May 16, 2024

Merged via the queue into master with commit 7fe7a6b May 16, 2024
39 checks passed

rosstimothy deleted the tross/auth_client branch May 16, 2024 17:51

rosstimothy mentioned this pull request May 17, 2024

[v15] Replace dependencies on lib/auth with lib/authclient #41714

Merged

rosstimothy mentioned this pull request May 17, 2024

[v14] Replace dependencies on lib/auth with lib/authclient #41716

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace dependencies on lib/auth with lib/authclient #41623

Replace dependencies on lib/auth with lib/authclient #41623

rosstimothy commented May 15, 2024 •

edited

rosstimothy May 15, 2024

tigrato left a comment

rosstimothy commented May 16, 2024

zmb3 commented May 16, 2024

public-teleport-github-review-bot bot commented May 16, 2024

Replace dependencies on lib/auth with lib/authclient #41623

Replace dependencies on lib/auth with lib/authclient #41623

Conversation

rosstimothy commented May 15, 2024 • edited

Items moved to authclient

Dependency Tree

master

tross/auth_client

rosstimothy May 15, 2024

Choose a reason for hiding this comment

tigrato left a comment

Choose a reason for hiding this comment

rosstimothy commented May 16, 2024

zmb3 commented May 16, 2024

public-teleport-github-review-bot bot commented May 16, 2024

rosstimothy commented May 15, 2024 •

edited