New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Validation and Editing Improvements #2389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdorn
changed the title
Simple JSON feature validation
JSON Validation and Editing Improvements
Apr 18, 2024
Your preview environment pr-2389-bttf has been deployed. Preview environment endpoints are available at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We currently support JSON Schema to validate feature values, but JSON Schema is very difficult to write from scratch unless you are very familiar with it.
Also, when editing a JSON feature's value, we just render a simple textarea instead of taking the JSON Schema into account (e.g. if the schema says it's an object with a two string fields, we should render two text inputs, not a single textarea).
Features and Changes
This PR has 4 main changes:
TODO: