Added SQL Server request timeout settings #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2493-bttf has been deployed. Preview environment endpoints are available at: |
lukesonnet
reviewed
May 8, 2024
| @@ -28,6 +28,7 @@ export default class Mssql extends SqlIntegration { | |||
| user: this.params.user, | |||
| password: this.params.password, | |||
| database: this.params.database, | |||
| requestTimeout: (this.params.requestTimeout ?? 0) * 1000, | |||
There was a problem hiding this comment.
Do you also need to set connectionTimeout (https://www.npmjs.com/package/mssql#general-same-for-all-drivers) to the same value, or let customers customize both?
There was a problem hiding this comment.
I thought about this—I have no problem adding, but it seems reasonable for the client to connect to the database within 15 seconds but unreasonable for all queries to complete within 15 seconds. I have no problem adding it if you think it's important.
jdorn
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL Server connections have a default timeout of 15 seconds. This has to be set when connecting. This PR adds a request timeout field that is user adjustable, and also increases the default time to 120 seconds.