Split out prettier, add prettierrc. #2504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the debacle around upgrading TS and prettier, it became pretty clear that we should be able to upgrade our formatting toolchain or our linting toolchain without impacting each other.
This PR splits out formatting from linting. This is inline with the most recent recommendations from eslint: https://eslint.org/blog/2023/10/deprecating-formatting-rules/
A
.prettiercfile is added to maintain consistency accros editors and formatting setups.Some changes will happen in the existing code, mostly around max line width. This might be related to how
prettiermakes line breaking decisions vs. eslint. See: https://prettier.io/docs/en/options.html#print-width