Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency rules_proto to v6 #4266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(deps): update dependency rules_proto to v6 #4266

wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 28, 2024 •
edited

Mend Renovate

This PR contains the following updates:

Package Type Update Change
rules_proto http_archive major 5.3.0-21.7 -> 6.0.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

bazelbuild/rules_proto (rules_proto)

v6.0.0

Compare Source

NEW FEATURES

When used with Bazel 7, Protobuf Toolchainization is now available. This allows you to choose where the protobuf compiler (protoc) comes from, as well as configure a toolchain for each language you generate proto stubs for.

This de-couples rules_proto from the https://github.com/protocolbuffers/protobuf repository; rules_proto no longer depends on com_google_protobuf. The Bazel rules in that repository are now maintained by the protobuf team for Google use cases, and may diverge from rules_proto over time.

rules_proto does not include the toolchain implementation. See https://registry.bazel.build/modules/toolchains_protoc for an example module that registers the prebuilt binary from https://github.com/protocolbuffers/protobuf/releases.

The tracking issue for this feature is #​179

BREAKING CHANGES

Upgrading from rules_proto 5.x requires some changes:

  • The load site for rules_proto_toolchains has changed. See the new WORKSPACE snippet below.
  • As mentioned above, rules_proto no longer depends on the protobuf repo (commonly as com_google_protobuf). As a result, the rules_proto_dependencies macro no longer fetches one. For WORKSPACE users, this may affect what version of protobuf you end up with. We recommend explicitly fetching com_google_protobuf early in the WORKSPACE file, as the first declaration wins.

Install

Using bzlmod with Bazel 6 or later:

  1. [Bazel 6] Add common --enable_bzlmod to .bazelrc.

  2. Add to your MODULE.bazel file:

bazel_dep(name = "rules_proto", version = "6.0.0")

Using WORKSPACE:

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_proto",
    sha256 = "303e86e722a520f6f326a50b41cfc16b98fe6d1955ce46642a5b7a67c11c0f5d",
    strip_prefix = "rules_proto-6.0.0",
    url = "https://github.com/bazelbuild/rules_proto/releases/download/6.0.0/rules_proto-6.0.0.tar.gz",
)

load("@​rules_proto//proto:repositories.bzl", "rules_proto_dependencies")
rules_proto_dependencies()

load("@​rules_proto//proto:toolchains.bzl", "rules_proto_toolchains")
rules_proto_toolchains()

What's Changed

New Contributors

Full Changelog: bazelbuild/rules_proto@4.0.0...6.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/rules_proto-6.x branch 3 times, most recently from 03b4dc1 to 8625646 Compare May 1, 2024 22:26
@renovate Renovate
Copy link
Contributor Author

renovate bot commented May 9, 2024 •
edited

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@johanbrandhorst johanbrandhorst mentioned this pull request May 9, 2024
Open
@johanbrandhorst johanbrandhorst force-pushed the renovate/rules_proto-6.x branch 2 times, most recently from 03c0c95 to f5a1809 Compare May 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johanbrandhorst