New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15991: Infogram pydocs updates #15992
base: rel-3.46.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you @shaunyogeshwaran !
>>> pcols = ["SEX", "MARRIAGE", "AGE"] | ||
>>> ig = H2OInfogram(protected_columns=pcols) | ||
>>> ig.train(y=y, x=x, training_frame=train) | ||
>>> ig.plot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is example for algorithm_params
I would expect call of ig.algorithm_params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @hannah-tillman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was wrong here. Its a example for data_fraction so I would expect. to call data_fractions..
So just call: ig.data_fraction
@@ -745,6 +762,23 @@ def total_information_threshold(self): | |||
information is the x-axis of the Core Infogram. Default is -1 which gets set to 0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope but I don't understand Default is -1 which gets set to 0.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the first line is not correct since the default is -0.1.
A number between 0 and 1 representing a threshold for total information, defaulting to 0.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @hannah-tillman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wendycwong any ideas about what's going on with the default values here?
(I can update the schema and fix the first line issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannah-tillman I understand it now.
It comes from here:
@wendycwong any reason why we not set it directly here?
Nevertheless, its out of scope of this PR. @shaunyogeshwaran.
>>> x = train.columns | ||
>>> x.remove(y) | ||
>>> pcols = ["SEX", "MARRIAGE", "AGE"] | ||
>>> ig = H2OInfogram(protected_columns=pcols, data_fraction=0.7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work the same as split_frame
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @hannah-tillman
@@ -768,6 +802,23 @@ def net_information_threshold(self): | |||
the y-axis of the Core Infogram. Default is -1 which gets set to 0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. First line says number between 0-1,... Default -1 sets to 0.1..
@@ -816,6 +884,23 @@ def safety_index_threshold(self): | |||
gets set to 0.1. | |||
|
|||
Type: ``float``, defaults to ``-1.0``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. First line says number between 0-1,... Default -1 sets to 0.1..
@@ -792,6 +843,23 @@ def relevance_index_threshold(self): | |||
which gets set to 0.1. | |||
|
|||
Type: ``float``, defaults to ``-1.0``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. First line says number between 0-1,... Default -1 sets to 0.1..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the examples works, but I would use different number than default to show how the parameter change the result, and I would rather avoid any unused stuff in the example. So the test should be used for some metric be deleted from example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @shaunyogeshwaran. Can you please run the all the examples ones again. E.g this will fail for sure.
And please merge it to re-3.46.0, the rel-3.44.0 is not used anymore. |
gives me:
Ticket here. |
The base branch was changed.
fixes #15991
Crafted new examples to showcase the different parameters.