[PUBDEV-9037] add hdfs_config argument to h2o.init method

[usefulalgorithm]

This PR implements https://h2oai.atlassian.net/browse/PUBDEV-9037.

It simply adds an additional optional argument to h2o.init, H2OLocalServer.start and H2OLocalServer._launch_server.

Thanks!

[usefulalgorithm]

CONTRIBUTING.md says:

New code must come with unit tests

However I'm really not sure how to write tests for this...

[mn-mikke]

Hi @usefulalgorithm,
IMHO this a good new feature, but would it be possible to make it more generic? Such arguments that would be rarely used in standalone deployment will be more. I’m thinking about adding a parameter called extra_args to init method of the python and R client. This parameter would be a dictionary and contain any additional arguments needed for starting h2o backend. E.g. h2o.init(extra_args= {'hdfs_config':'core-site.xml', …} ) WDYT?

[usefulalgorithm]

Hi @mn-mikke , thanks for the suggestion, just added a new commit to the branch!

[usefulalgorithm]

ping

[usefulalgorithm]

Hi @mn-mikke , sorry for the late update, I fixed it like you suggested. Thanks!

[usefulalgorithm]

ping

[usefulalgorithm]

Hi @mn-mikke , is there any update regarding this PR? It's been stuck for quite awhile. If there is anything else I can do to help this PR get moving, please let me know. Thanks!

[mn-mikke]

Hi @usefulalgorithm,
deeply sorry for late reply. It looks good to me. Please rebase your change against branch rel-3.42.0 and we will release with the next fix release.