Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Decimal support Progress Table Cell Type #824 #2226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

modhurimaroy
Copy link

Closes #824, introduces an optional parameter for including decimal values in Progress Table Cell Type, and includes new test cases to ensure the new feature is functional.
The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

@mturoci
Copy link
Collaborator

mturoci commented Dec 14, 2023

Hi @modhurimaroy, there is no need for a new param. The goal of the issue is to render a decimal value if provided (it's currently rounded), otherwise display an integer as today. Make sure there are max 2 decimal. places.

@mturoci
Copy link
Collaborator

mturoci commented Dec 14, 2023

Also please close the other PR so that we do not have duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support decimal values in table progress cell type
2 participants