Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BigInteger for C# pidigits #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jjxtra
Copy link

@jjxtra jjxtra commented Oct 23, 2022

C# BigInteger is known to be poorly implemented for performance, so have removed it to give a better showing of the compiler with raw math

C# BigInteger is known to be poorly implemented for performance, so have removed it to give a better showing of the compiler with raw math
@jjxtra
Copy link
Author

jjxtra commented Oct 23, 2022

Let me know if you want this in a new file instead

@hanabi1224
Copy link
Owner

hanabi1224 commented Oct 26, 2022

Thanks for the new version, however, it breaks comparability to other implementations. For this problem, all implementations should use a general-purpose big integer library. And in this case, it's more of evaluating the ecosystem than the compiler itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants