Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Context.getShortcuts type #10910

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

fanshi1028
Copy link
Contributor

Context

fix outdated type

How has this been tested?

Nope

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@adrianszymanski89
Copy link
Contributor

adrianszymanski89 commented Apr 15, 2024

Hi @fanshi1028

Thank you for your contribution! We will review your PR and update you when we check if we can merge it.

Before that, please add a changelog entry and tests for the new type. Thank you.

@fanshi1028
Copy link
Contributor Author

Hi @fanshi1028

Thank you for your contribution! We will review your PR and update you when we check if we can merge it.

Before that, please add a changelog entry and tests for the new type. Thank you.

Added a changelog but I don't know where/what to add tests for this fix.

@AMBudnik
Copy link
Contributor

@jansiegel jansiegel merged commit 7230ce6 into handsontable:develop Jun 5, 2024
17 of 18 checks passed
jansiegel added a commit that referenced this pull request Jun 5, 2024
* fix Context.getShortcuts type

* add changelog

* add a test for getShortcuts type fix

---------

Co-authored-by: Aleksandra Budnik <AMBudnik@users.noreply.github.com>
Co-authored-by: Jan Siegel <jansiegel@users.noreply.github.com>
jansiegel added a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants