Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-5879 - expose sameness group param on service health endpoint and move sameness group health fallback logic into HealthService RPC layer #21096

Merged
merged 5 commits into from
May 14, 2024
Merged

NET-5879 - expose sameness group param on service health endpoint and move sameness group health fallback logic into HealthService RPC layer #21096

merged 5 commits into from
May 14, 2024

Conversation

jmurret
Copy link
Contributor

@jmurret jmurret commented May 13, 2024

Description

  • expose a sameness group query parameter (sameness-group or sg) on the service health endpoint
  • expose SamenessGroup on ServiceSpecificRequest struct
  • move sameness group logic into RPC layer so that health filter occurs behind the RPC layer and under one watchset rather than multiple RPC calls.
  • this currently does not allow streaming when the SamenessGroup on the ServiceSpecificRequest is not empty because additional work needs to be done to enable this type composite query (potentially view) within the streaming API.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels May 13, 2024
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality labels May 13, 2024
@jmurret jmurret requested a review from a team as a code owner May 13, 2024 22:41
@jmurret jmurret force-pushed the jm/consolidate-sameness branch 3 times, most recently from 3cbdc3c to 082ac1a Compare May 13, 2024 23:39
@jmurret jmurret enabled auto-merge (squash) May 14, 2024 13:07
@jmurret jmurret merged commit 9b2c1be into main May 14, 2024
85 checks passed
@jmurret jmurret deleted the jm/consolidate-sameness branch May 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roncodingenthusiast roncodingenthusiast roncodingenthusiast approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmurret @roncodingenthusiast