Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 to the gemspec #13390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hswong3i
Copy link

base64 will no longer be the default gem in the Ruby 3.4, without this patch following warning message may come from ruby 3.3+

/opt/vagrant/lib/vagrant/util/powershell.rb:4: warning: base64 was
loaded from the standard library, but will no longer be part of the
default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

See thinreports/thinreports-generator#134

base64 will no longer be the default gem in the Ruby 3.4, without this
patch following warning message may come from ruby 3.3+

    /opt/vagrant/lib/vagrant/util/powershell.rb:4: warning: base64 was
    loaded from the standard library, but will no longer be part of the
    default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

See thinreports/thinreports-generator#134

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Copy link

hashicorp-cla-app bot commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

hswong3i added a commit to alvistack/hashicorp-vagrant that referenced this pull request May 11, 2024
    git clean -xdf
    git submodule sync --recursive
    git submodule update --recursive --init
    git submodule foreach --recursive git clean -xdf
    gem build vagrant.gemspec -o ../vagrant-2.4.1.gem
    bundle config set --local path ./bundle
    bundle install --verbose --standalone
    bundle config set --local cache_all true
    bundle config set --local cache_all_platforms true
    bundle cache
    mv ../vagrant-2.4.1.gem ./vendor/cache/
    rm -rf .bundle bundle vendor/bundle Gemfile.lock
    tar zcvf ../vagrant_2.4.1.orig.tar.gz --exclude=.git .
    debuild -uc -us
    cp vagrant.spec ../vagrant_2.4.1-1.spec
    cp vagrant.rpmlintrc /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
    cp ../vagrant*2.4.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/hashicorp-vagrant-2.4.1/
    rm -rf ../vagrant*2.4.1*.*

See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0001-bin-vagrant-silence-warning-about-installer.patch
See https://salsa.debian.org/ruby-team/vagrant/-/blob/master/debian/patches/0005-Relax-dependency-resolution.patch
See https://build.opensuse.org/package/show/openSUSE:Factory/vagrant
See hashicorp#13390

Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant