Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Tests and Fix for user enumeration bug #5229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Tests and Fix for user enumeration bug #5229

wants to merge 2 commits into from
+36 −5

Conversation

PvtSec
Copy link

@PvtSec PvtSec commented Apr 7, 2024 •
edited by haiodo

Changes made:

Huly®: UBERF-6397

@PvtSec PvtSec mentioned this pull request Apr 7, 2024
Closed
@haiodo haiodo self-requested a review April 9, 2024 11:01
haiodo
haiodo requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@haiodo haiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PvtSec
Thanks for a contribution, but some work is still to be done accept changes. Thanks.

README.md Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
server/account/src/index.ts Show resolved Hide resolved
@PvtSec
Fix: User enum bug
46b873f 
Signed-off-by: akshay <akssofts@gmail.com>
@PvtSec
Copy link
Author

PvtSec commented Apr 14, 2024

Hi @haiodo ,

  • Reverted changes
  • Keeps logging for older states
  • Resolved all comments.

Ready for a new review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
changes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PvtSec @haiodo