Handle duplicate file names in bufferline by prepending parent dir #10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metafates
force-pushed
the
master
branch
2 times, most recently
from
2fd2098
to
1fac1be
Compare
|
See also #5092 |
metafates
force-pushed
the
master
branch
3 times, most recently
from
201d4e9
to
0571316
Compare
the-mikedavis
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors bufferline rendering logic by prepending minimum required parent directories for each conflicting file name, therefore resolving duplicates. This is very common feature seen in code editors such as JetBrains IDE, VSCode etc.
Before:
After: