New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-17375 HQL syntax sugar for array operations #8330

Merged

beikov merged 10 commits into hibernate:main from beikov:HHH-17375

May 13, 2024

Contributor

beikov commented May 7, 2024 •

edited by hibernate-github-bot bot

https://hibernate.atlassian.net/browse/HHH-17375
https://hibernate.atlassian.net/browse/HHH-18089

Member

gavinking commented May 7, 2024

Nice!

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java Outdated

+              					Class<?> javaTypeClass = jdbcMapping.getJavaTypeDescriptor().getJavaTypeClass();
+              					if ( javaTypeClass == Boolean.class ) {
+              						// BooleanJavaType has this as an implicit conversion
+              						return Integer.parseInt( string, start, end, 10 ) == 1;

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

hibernate-core/src/main/java/org/hibernate/dialect/JsonHelper.java Outdated

+              						return Integer.parseInt( string, start, end, 10 ) == 1;
+              					}
+              					if ( javaTypeClass.isEnum() ) {
+              						return javaTypeClass.getEnumConstants()[Integer.parseInt( string, start, end, 10 )];

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArrayAggEmulation.java Outdated

Comment on lines 74 to 76

+              			throw new SemanticException(
+              					"Oracle array_agg emulation requires a basic plural return type, but resolved return type was: " + returnType
+              			);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking

SemanticException.SemanticException

should be avoided because it has been deprecated.

...e-core/src/main/java/org/hibernate/tool/schema/internal/StandardUserDefinedTypeExporter.java Outdated

@@ @@ -125,4 +161,8 @@ @@
               		return new String[] { buf.toString() };
               	}
+              	public String[] getSqlDropStrings(UserDefinedArrayType userDefinedType, Metadata metadata, SqlStringGenerationContext context) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'metadata' is never used.

...e-core/src/main/java/org/hibernate/tool/schema/internal/StandardUserDefinedTypeExporter.java Outdated

+              		}
+              	}
+              	public String[] getSqlDropStrings(UserDefinedObjectType userDefinedType, Metadata metadata, SqlStringGenerationContext context) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'metadata' is never used.

...e-core/src/main/java/org/hibernate/tool/schema/internal/StandardUserDefinedTypeExporter.java Outdated

+              		}
+              	}
+              	public String[] getSqlDropStrings(UserDefinedObjectType userDefinedType, Metadata metadata, SqlStringGenerationContext context) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method StandardUserDefinedTypeExporter.getSqlDropStrings(..) could be confused with overloaded method

getSqlDropStrings

, since dispatch depends on static types.

...e-core/src/main/java/org/hibernate/tool/schema/internal/StandardUserDefinedTypeExporter.java Outdated

@@ @@ -82,12 +99,19 @@ @@
               		}
               	}
+              	public String[] getSqlCreateStrings(

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method StandardUserDefinedTypeExporter.getSqlCreateStrings(..) could be confused with overloaded method

getSqlCreateStrings

, since dispatch depends on static types.

...e-core/src/main/java/org/hibernate/tool/schema/internal/StandardUserDefinedTypeExporter.java Outdated

+              		}
+              	}
+              	public String[] getSqlCreateStrings(

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method StandardUserDefinedTypeExporter.getSqlCreateStrings(..) could be confused with overloaded method

getSqlCreateStrings

, since dispatch depends on static types.

hibernate-core/src/main/java/org/hibernate/dialect/StructJdbcType.java Outdated

               import org.hibernate.type.spi.TypeConfiguration;
               /**
                * @author Christian Beikov
                */
-              public class StructJdbcType implements AggregateJdbcType {
+              public class StructJdbcType implements org.hibernate.type.descriptor.jdbc.StructJdbcType {

Check notice

Code scanning / CodeQL

Class has same name as super class Note

StructJdbcType has the same name as its supertype

org.hibernate.type.descriptor.jdbc.StructJdbcType

.

hibernate-core/src/main/java/org/hibernate/mapping/AbstractUserDefinedType.java Outdated

+              	}
+              	@Override
+              	public boolean equals(Object object) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method AbstractUserDefinedType.equals(..) could be confused with overloaded method

equals

, since dispatch depends on static types.

beikov force-pushed the HHH-17375 branch 2 times, most recently from 0b01125 to e24a948 Compare

May 7, 2024 15:56

beikov marked this pull request as ready for review

May 7, 2024 19:01

beikov force-pushed the HHH-17375 branch 3 times, most recently from 9ef3fa3 to 99d9173 Compare

May 7, 2024 22:25

gavinking reviewed

View reviewed changes

release-announcement.adoc Show resolved Hide resolved

beikov force-pushed the HHH-17375 branch 2 times, most recently from 2e1108d to aca4cd9 Compare

May 13, 2024 06:40

beikov added 10 commits

May 13, 2024 10:24


          HHH-17375 Shorthand bracket syntax for array construction

f8ac266


          HHH-17375 Shorthand bracket syntax for array slicing

e2f4e13


          HHH-17375 Overload length function with array_length semantics on arr…

3b70d66

…ay input


          HHH-17375 Overload position function with array_position semantics on…

dbed0b3

… array input


          HHH-17375 Support casting array to string and add optional third argu…

13f8561

…ment to array_to_string for null element handling


          HHH-17375 Introduce contains predicate for easy array containment che…

8b3c5c8

…cking


          HHH-17375 Introduce intersects predicate for easy array_intersects, t…

763dc50

…he replacement of array_overlaps


          HHH-17375 Support array on RHS of in predicate

c24d30b


          HHH-17375 Introduce array_includes() and INCLUDES predicate for check…

b0e79c0

…ing if array contains all elements of subarray as replacement to array_contains() overload


          HHH-18089 Support bracket syntax with string types

af030e4

beikov force-pushed the HHH-17375 branch from aca4cd9 to af030e4 Compare

May 13, 2024 08:24

github-advanced-security bot found potential problems

View reviewed changes

.../main/java/org/hibernate/query/sqm/produce/function/StandardFunctionReturnTypeResolvers.java


		@Internal
		public static boolean isAssignableTo(JdbcMapping defined, JdbcMapping implied) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method StandardFunctionReturnTypeResolvers.isAssignableTo(..) could be confused with overloaded method

isAssignableTo

, since dispatch depends on static types.

beikov merged commit 8b5cdba into hibernate:main

23 of 25 checks passed

beikov deleted the HHH-17375 branch

May 22, 2024 11:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment