Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18056 SQL Server, Sybase, and HANA should allow @Table(options) #8353

Closed

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented May 11, 2024

Looks to me like SQL Server, Sybase, and HANA all do support some kind of create table options.

But @dreab8, I'm not sure how much value there is to even having Table.supportsTableOptions(). Derby was the only database I could find which doesn't allow anything after the closing paren of create table. And it's not like these table options are ever portable between databases.

And just silently ignoring what the user specified on certain databases is pretty fragile to begin with anyway.

https://hibernate.atlassian.net/browse/HHH-18056

Signed-off-by: Gavin King <gavin@hibernate.org>
@gavinking gavinking requested a review from dreab8 May 11, 2024 09:52
@dreab8
Copy link
Member

dreab8 commented May 13, 2024

Hi @gavinking , yes I was non completely sure about the Dialect.supportsTableOptions()setting and I'm not against removing it, let's also see what @sebersole @beikov and @mbladel think.

@beikov
Copy link
Contributor

beikov commented May 13, 2024

I'd prefer if we remove Dialect.supportsTableOptions() and just let it fail on execution. It's not like we can help the user in any way with this.

@dreab8
Copy link
Member

dreab8 commented May 13, 2024

The PR that removes the setting

@beikov
Copy link
Contributor

beikov commented May 13, 2024

Closing since #8367 removed the method.

@beikov beikov closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants