Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-18102 - @CheckHQL is not reporting error when non-existing enum constant is referenced in named HQL query #8365

Merged
merged 3 commits into from May 13, 2024
Merged

HHH-18102 - @CheckHQL is not reporting error when non-existing enum constant is referenced in named HQL query #8365

merged 3 commits into from May 13, 2024

Conversation

cigaly
Copy link
Contributor

@cigaly cigaly commented May 13, 2024 •
edited by jira bot

See Jira issue HHH-18102

Method org.hibernate.processor.validation.MockSessionFactory.MockJpaMetamodelImpl#enumValue is not checking for enum value existence

@cigaly
Copy link
Contributor Author

cigaly commented May 13, 2024

First commit is only making minor changes to allow other two to be (if accepted) merged without conflicts with PR 8095.

gavinking
gavinking approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinking
Copy link
Member

Thanks for this, the fix is perfect.

@gavinking gavinking merged commit 9f06bbb into hibernate:main May 13, 2024
22 of 23 checks passed
@cigaly cigaly deleted the HHH-18102-CheckHQL_not_reporting_bad_enum_constant branch May 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinking gavinking gavinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cigaly @gavinking