Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-18057 Support for JPA 3.2 column options #8366

Merged
merged 1 commit into from May 13, 2024
Merged

HHH-18057 Support for JPA 3.2 column options #8366

merged 1 commit into from May 13, 2024

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented May 13, 2024

github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2024
View reviewed changes
...-core/src/test/java/org/hibernate/orm/test/schemaupdate/columnoptions/ColumnOptionsTest.java

@BeforeEach
public void setUp() throws IOException {
output = File.createTempFile( "update_script", ".sql" );

Check warning

Code scanning / CodeQL

Local information disclosure in a temporary directory Medium

Local information disclosure vulnerability due to use of file readable by other local users.
hibernate-core/src/main/java/org/hibernate/tool/schema/internal/ColumnDefinitions.java
appendOptions(statement, column, dialect);
}

private static void appendOptions(StringBuilder statement, Column column, Dialect dialect) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'dialect' is never used.
...-core/src/test/java/org/hibernate/orm/test/schemaupdate/columnoptions/ColumnOptionsTest.java

private static boolean tableCreationStatementContainsOptions(
File output,
String columnName,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'columnName' is never used.
@sebersole sebersole merged commit 129162b into hibernate:wip/7.0 May 13, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beikov beikov beikov approved these changes

@gavinking gavinking gavinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dreab8 @beikov @gavinking @sebersole