Fix add_text_point #2293
Open
Fix add_text_point #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Fix add_text_point
about: Create a pull request to help us improve
title: Fix add_text_point
Description:
The
add_text_point()function used to throw an exception when called because of a simple error during the parsing of the parameters.That has been fixed, but it also has been changed x_offset and y_offset which have been brought to the same variable
offset. Actually these variables didn't have a default value then they used to make throw an exception if not specified.Also the type notation of the x and y values have been changed according on how they are handled in the code.
Fixes #2108