Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSO Energy binary sensors #117174

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

osohotwateriot
Copy link
Contributor

@osohotwateriot osohotwateriot commented May 10, 2024

Breaking change

Proposed change

Add binary sensors to OSO Energy

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @osohotwateriot for contributing!

The PR looks good so far! The description listed that tests had been added, but I didn't see any. If not adding any, please can you update the PR description? Adding tests really helps if you can do that.

I would also recommend adding an icons.json to give a default icon to the new sensors.

@@ -988,6 +988,7 @@ omit =
homeassistant/components/oru/*
homeassistant/components/orvibo/switch.py
homeassistant/components/osoenergy/__init__.py
homeassistant/components/osoenergy/binary_sensor.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add tests for these new sensors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the default icons in the icons.json file and updated the PR description for the unit tests.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 12, 2024 19:17
@osohotwateriot osohotwateriot marked this pull request as ready for review May 13, 2024 11:24
@home-assistant home-assistant bot requested a review from davet2001 May 13, 2024 11:24
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - sorry for the extra questions - I don't have any way to see what's in the data. If you have some example returned data dicts or a test API that would help.

The main question is around whether device_id includes a unique identifier.

Thanks for adding the icons!

homeassistant/components/osoenergy/binary_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 16:59
@osohotwateriot osohotwateriot marked this pull request as ready for review May 14, 2024 06:48
@home-assistant home-assistant bot requested a review from davet2001 May 14, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants