refactor(secure-headers): don't use Partial for the options (#2713)

honojs · May 18, 2024 · 9540e69 · 9540e69
1 parent b7d72fd
commit 9540e69
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/deno_dist/middleware/secure-headers/index.ts b/deno_dist/middleware/secure-headers/index.ts
@@ -58,7 +58,7 @@ interface SecureHeadersOptions {
   crossOriginEmbedderPolicy?: overridableHeader
   crossOriginResourcePolicy?: overridableHeader
   crossOriginOpenerPolicy?: overridableHeader
-  originAgentCluster: overridableHeader
+  originAgentCluster?: overridableHeader
   referrerPolicy?: overridableHeader
   reportingEndpoints?: ReportingEndpointOptions[]
   reportTo?: ReportToOptions[]
@@ -126,7 +126,7 @@ export const NONCE: ContentSecurityPolicyOptionHandler = (ctx) => {
   return `'nonce-${nonce}'`
 }
 
-export const secureHeaders = (customOptions?: Partial<SecureHeadersOptions>): MiddlewareHandler => {
+export const secureHeaders = (customOptions?: SecureHeadersOptions): MiddlewareHandler => {
   const options = { ...DEFAULT_OPTIONS, ...customOptions }
   const headersToSet = getFilteredHeaders(options)
   const callbacks: SecureHeadersCallback[] = []

diff --git a/src/middleware/secure-headers/index.ts b/src/middleware/secure-headers/index.ts
@@ -57,7 +57,7 @@ interface SecureHeadersOptions {
   crossOriginEmbedderPolicy?: overridableHeader
   crossOriginResourcePolicy?: overridableHeader
   crossOriginOpenerPolicy?: overridableHeader
-  originAgentCluster: overridableHeader
+  originAgentCluster?: overridableHeader
   referrerPolicy?: overridableHeader
   reportingEndpoints?: ReportingEndpointOptions[]
   reportTo?: ReportToOptions[]
@@ -125,7 +125,7 @@ export const NONCE: ContentSecurityPolicyOptionHandler = (ctx) => {
   return `'nonce-${nonce}'`
 }
 
-export const secureHeaders = (customOptions?: Partial<SecureHeadersOptions>): MiddlewareHandler => {
+export const secureHeaders = (customOptions?: SecureHeadersOptions): MiddlewareHandler => {
   const options = { ...DEFAULT_OPTIONS, ...customOptions }
   const headersToSet = getFilteredHeaders(options)
   const callbacks: SecureHeadersCallback[] = []