Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: body parser helper #1389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

krsbx
Copy link

@krsbx krsbx commented Aug 30, 2023

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

What this PR do?

Adding BodyParser.parse helper just like the one we have on qs so we could have some sort of (bodyParser.urlencoded({ extended: true }))[#1184] in hono

@yusukebe
Copy link
Member

I can't merge it immediately because it's not needed in the Hono core package, because you can use the qs instead.

@rafaell-lycan
Copy link

@krsbx perhaps this would make sense being a 3rd-party middleware.

@yusukebe WDYT?

@krsbx
Copy link
Author

krsbx commented Oct 16, 2023

@rafaell-lycan actually my idea is that the user can just import this helper and parse the user request body

I think it's much better if we just add some sort a params in the req.json so the user can parse the request body with the helper or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants