perf(compose): simplify #1701
Merged
perf(compose): simplify #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @usualoma ! Could you review this? |
|
Thanks! I've reconsidered and decided it's not necessary to wait for the next minor version release. So, I'll merge this into the main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I've refactored
compose.tsto simplify it and improve performance.We might consider adding changes to enhance performance as mentioned in this comment.
However, let's first focus on merging this refactoring. Although it's a
perfchange, it could be related to a new feature, so we should merge it into thenextbranch.Author should do the followings, if applicable
yarn denoifyto generate files for Deno